test_transport fails sometimes with an AlreadyCancelledError

[Christopher Armstrong]

This sometimes happens:

===============================================================================
[ERROR]: landscape.broker.tests.test_transport.HTTPTransportTest.test_ssl_verification_negative

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/twisted/python/log.py", line 48, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/usr/lib/python2.5/site-packages/twisted/python/log.py", line 33, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/lib/python2.5/site-packages/twisted/python/context.py", line 59, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib/python2.5/site-packages/twisted/python/context.py", line 37, in callWithContext
    return func(*args,**kw)
  File "/usr/lib/python2.5/site-packages/twisted/internet/gtk2reactor.py", line 203, in _doReadOrWrite
    self._disconnectSelectable(source, why, didRead == source.doRead)
  File "/usr/lib/python2.5/site-packages/twisted/internet/posixbase.py", line 252, in _disconnectSelectable
    selectable.readConnectionLost(f)
  File "/usr/lib/python2.5/site-packages/twisted/internet/tcp.py", line 405, in readConnectionLost
    self.connectionLost(reason)
  File "/usr/lib/python2.5/site-packages/twisted/internet/tcp.py", line 416, in connectionLost
    protocol.connectionLost(reason)
  File "/usr/lib/python2.5/site-packages/twisted/web/http.py", line 1110, in connectionLost
    self.setTimeout(None)
  File "/usr/lib/python2.5/site-packages/twisted/protocols/policies.py", line 525, in setTimeout
    self.__timeoutCall.cancel()
  File "/usr/lib/python2.5/site-packages/twisted/internet/base.py", line 93, in cancel
    raise error.AlreadyCancelled
twisted.internet.error.AlreadyCancelled: Tried to cancel an already-cancelled event.
-------------------------------------------------------------------------------

[Christopher Armstrong (radix)]

Ok, ready for review in the attached branch.

[Jamu Kakar (jkakar)]

Marking as 'High' as this affects the PQM/Xen work Tom is doing.

[Jamu Kakar (jkakar)]

[1]

+ def got_result(result):

Would you mind renaming 'result' to 'ignored' in the cases you've
added these calls.

Everything looks good and tests pass here on hardy, +1!

[Thomas Herve (therve)]

Great, the problem is fixed here, +1. Small nits:

One flake:
landscape/broker/tests/test_transport.py:5: 'API' imported but unused

and one trailing whitespace.

[Christopher Armstrong (radix)]

Thanks, it's in trunk now.