Launchpad itself

easily create team when needed

Bug #250955 reported by Edwin Grubbs
10
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Ian Booth

Bug Description

Even if we provide lots of convenient links to http://launchpad.net/people/+newteam it interrupts the workflow of assigning a team in a form.

This can be improved by having a popup next to the "Choose..." popup which allows you to create a new team. Creating a team should not be done from inside the "Choose..." popup, since people will never look there for a way to create a team.

Related branches

lp:~wallyworld/launchpad/new-team-picker
Curtis Hovey (community): Approve (code)
Jelmer Vernooij: Pending requested
Diff: 1171 lines (+491/-226)
11 files modified
lib/lp/app/browser/lazrjs.py (+10/-2)
lib/lp/app/browser/tests/test_inlineeditpickerwidget.py (+20/-2)
lib/lp/app/javascript/picker/person_picker.js (+148/-18)
lib/lp/app/javascript/picker/picker.js (+82/-16)
lib/lp/app/javascript/picker/picker_patcher.js (+17/-36)
lib/lp/app/javascript/picker/tests/test_personpicker.html (+2/-0)
lib/lp/app/javascript/picker/tests/test_personpicker.js (+158/-135)
lib/lp/app/widgets/popup.py (+23/-13)
lib/lp/app/widgets/tests/test_popup.py (+21/-0)
lib/lp/registry/browser/product.py (+4/-4)
lib/lp/services/features/flags.py (+6/-0)
lp:~wallyworld/launchpad/new-team-picker-simple-form
Richard Harding (community): Approve
Curtis Hovey (community): Needs Fixing (code)
Diff: 840 lines (+492/-156)
9 files modified
lib/lp/app/javascript/picker/person_picker.js (+31/-137)
lib/lp/app/javascript/picker/team.js (+218/-0)
lib/lp/app/javascript/picker/tests/test_personpicker.html (+2/-0)
lib/lp/app/javascript/picker/tests/test_personpicker.js (+22/-18)
lib/lp/app/javascript/picker/tests/test_team.html (+50/-0)
lib/lp/app/javascript/picker/tests/test_team.js (+110/-0)
lib/lp/registry/browser/configure.zcml (+6/-0)
lib/lp/registry/browser/team.py (+27/-1)
lib/lp/registry/browser/tests/test_team.py (+26/-0)
lp:~wallyworld/launchpad/new-team-picker-load-form
Curtis Hovey (community): Approve (code)
Diff: 1007 lines (+326/-204)
11 files modified
lib/lp/app/javascript/formoverlay/formoverlay.js (+4/-4)
lib/lp/app/javascript/picker/person_picker.js (+124/-86)
lib/lp/app/javascript/picker/picker.js (+62/-37)
lib/lp/app/javascript/picker/picker_patcher.js (+5/-6)
lib/lp/app/javascript/picker/tests/test_personpicker.html (+22/-5)
lib/lp/app/javascript/picker/tests/test_personpicker.js (+62/-6)
lib/lp/app/javascript/picker/tests/test_picker_patcher.js (+34/-23)
lib/lp/app/javascript/subscribers/subscribers_list.js (+6/-6)
lib/lp/bugs/javascript/filebug_dupefinder.js (+2/-2)
lib/lp/registry/javascript/sharing/shareepicker.js (+0/-24)
lib/lp/registry/javascript/sharing/tests/test_shareepicker.js (+5/-5)
lp:~wallyworld/launchpad/new-team-picker-enhanced-form
Richard Harding (community): Approve (code)
Diff: 814 lines (+265/-67)
15 files modified
lib/lp/app/javascript/choice.js (+40/-27)
lib/lp/app/javascript/picker/team.js (+8/-1)
lib/lp/app/javascript/picker/tests/test_personpicker.html (+2/-0)
lib/lp/app/javascript/picker/tests/test_team.html (+22/-0)
lib/lp/app/javascript/picker/tests/test_team.js (+57/-4)
lib/lp/bugs/javascript/tests/test_filebug.js (+16/-12)
lib/lp/registry/browser/configure.zcml (+1/-1)
lib/lp/registry/browser/distribution.py (+4/-3)
lib/lp/registry/browser/pillar.py (+30/-7)
lib/lp/registry/browser/product.py (+5/-4)
lib/lp/registry/browser/productseries.py (+2/-2)
lib/lp/registry/browser/project.py (+4/-3)
lib/lp/registry/browser/tests/test_distribution.py (+28/-1)
lib/lp/registry/browser/tests/test_product.py (+16/-0)
lib/lp/registry/browser/tests/test_projectgroup.py (+30/-2)
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

We already have a basic form of this, in object-reassignment.pt.

I suggest adding an "A new team..." item at the end of the autocomplete menu for specifying a (person or) team, once it replaces the "Choose..." frame. (This assumes that implementing the autocomplete menu should be a much higher priority than implementing the ability to create teams on the fly.)

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

object-reassignment.pt is no longer used for setting the owner of a project, since it is combined with the page for setting the driver on the People tab of Change Details.

Salgado mentioned that add "A new team" to the end of the autocomplete menu won't work since users already know that the team doesn't exist, so they don't see how it will help to search for it or to click on the Choose link.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I don't understand what you mean. People wouldn't need to know to click the Choose link; the Choose link wouldn't exist any more.

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

A user won't enter anything into the box to trigger the autocomplete menu if they know they need to create a team first, since they won't expect the autocomplete menu to have that option.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I think that by the time they first come into this situation, they will expect the menu to contain that option, because they will have seen it dozens of times already.

Revision history for this message
Arthur Hebert (ahebert) wrote :

I am new to LaunchPad, and trying to figure out how to create a new team. I see from this bug, that http://launchpad.net/people/+newteam is what I need. I've been trying to find such a link for 15 minutes. I might have missed something obvious; but since, this discussion seems to be about whether users know how to create a team, I thought I'd mention it.

Curtis Hovey (sinzui)
affects: launchpad-foundations → launchpad-registry
Changed in launchpad-registry:
importance: Undecided → Low
status: New → Triaged
Curtis Hovey (sinzui)
tags: added: teams
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15475 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15475) is part of this bug's fix.

Changed in launchpad:
assignee: nobody → Ian Booth (wallyworld)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → In Progress
Ian Booth (wallyworld)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15492 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15492) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Ian Booth (wallyworld)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15531 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15531>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Ian Booth (wallyworld)
tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15542 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15542>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Ian Booth (wallyworld)
tags: added: qa-ok
removed: qa-needstesting
Steve Kowalik (stevenk)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
tags: added: disclosure sharing
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.