qdiff: wrong diff for removed file

[Alexander Belchenko]

qdiff show removed file wrong in both view.
Side-by-side (SBS) view don't show file info/properties and underline horizontal line at all (see attached screenshot).

Unidiff view is also show wrong info for removed:

=== modified file a
--- a 2008-07-19 19:04:35 +0000
+++ a 2008-07-19 19:05:31 +0000
@@ -1,1 +1,1 @@
-bar
+eggs

=== renamed and modified file b
--- None 1970-01-01 00:00:00 +0000
+++ None 1970-01-01 00:00:00 +0000

While bzr diff show correct output:

=== modified file 'a'
--- a 2008-07-19 19:04:35 +0000
+++ a 2008-07-19 19:05:31 +0000
@@ -1,1 +1,1 @@
-bar
+eggs

=== removed file 'b'
--- b 2008-07-19 19:04:35 +0000
+++ b 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
-spam

[Alexander Belchenko (bialix)]

It will be nice to have unittest at least for unidiff.

[Gary van der Merwe (garyvdm)]

With regard to side by side diffs, this was done intentionally. I feel that it gives a good visual indication that the file was not there before, or not there after.

I will be easy to change if you disagree.

[Alexander Belchenko (bialix)]

Gary van der Merwe пишет:
> With regard to side by side diffs, this was done intentionally. I feel
> that it gives a good visual indication that the file was not there
> before, or not there after.

Please, looks closer at attached screenshot. I'm agree about idea,
but disagree about implementation: there is no stat info for removed entry,
no underlined horizontal line, no removed content -- only file name.
I talk about *this* as bug, not about showing entry only on left side of SBS.