setup.py does not remove old files (moved to lib/)

[Gary van der Merwe]

I did a ./setup install on my laptop of the latest trunk. I did not work correctly. I had to delete build and the installed dir and then run it again. I believe this is due to moving the files to lib/.

Once fixed, we should also check that other install methods, such as the windows installer, and .deb and not affected by this bug.

[Alexander Belchenko (bialix)]

I don't understand the problem. It works correct for me. See attached log of manual installation. Although I'd recommend to build python-based installer and use qbzr-X.X.X.win32.exe to install it for your Python, because then you'll have corresponding entry in Add/Remove Dialog (I assume you're on Windows). I can't test it on Linux, sorry.

[Gary van der Merwe (garyvdm)]

I'll have access to my linux machine tomorrow. I'll try and reproduce and report on Sunday.

I did a test on windows installing 0.9.1 and then 0.9.2 with python setup.py install. It installed correctly, but did not delete the old files that have been move. I feel this needs to be fixed.

[Alexander Belchenko (bialix)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gary van der Merwe пишет:
| I did a test on windows installing 0.9.1 and then 0.9.2 with python
| setup.py install. It installed correctly, but did not delete the old
| files that have been move. I feel this needs to be fixed.

Ah. This is known problem with standard Python's distutils.
If you feel we should fix it by self, we could do this.
I just want to say that it's not because our setup.py is incorrect,
but because standard distutils does not provide neither uninstall
nor update action.

So we need custom install action that will cleanup old files before
copying new ones. Take a look at bzr's setup.py for reference.

|
| ** Changed in: qbzr
| Importance: Critical => High

I feel we could lower priority of this a bit more.

| Assignee: (unassigned) => Gary van der Merwe (garyvdm)
| Status: Incomplete => New

 status confirmed
 importance medium
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIgOhdzYr338mxwCURAi7iAJ9EvIE8DYv+0TvTXKZjAHfQPlBfNwCgl04Y
qjn/06It5AIJJ6pFHyUckuo=
=rZjf
-----END PGP SIGNATURE-----

[Alexander Belchenko (bialix)]

So what we will do about this?

If we will fix this for plain `setup.py install` then probably we need to write special clean-up script for python-based installer? Or maybe it's much simpler to ask our users to uninstall old version first?

I don't feel urgent need for fixing distutils bugs though. Will be nice to delete old files, but...

[Alexander Belchenko (bialix)]

I wrote special warning in NEWS and 0.9.2 announce about removing old files first when user upgrading from older version. I'm inclined to mark this bug as Won't Fix.

[Gary van der Merwe (garyvdm)]

Ok