bzr log -r REVNO does what bzr log -c should do

[Scott James Remnant (Canonical)]

consistency, guys ;-)

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Scott James Remnant wrote:
> Public bug reported:
>
> consistency, guys ;-)

log and diff effectively use different sets.

log uses an inclusive set, so log -r 1..2 displays the log messages for
revisions 1 and 2. diff -r 1..2 displays only the changes introduced by
2. diff -c 2 is equivalent to "diff -r 1..2".

In order to be *consistent*, log -c 2 would therefore display the logs
of revisions 1 and 2, and I assert that this is not very useful.

Aaron

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIe3lM0F+nu1YWqI0RAv2uAJ9aXwfj8VdD112G5A+tlDAf0rcZhACfR9qh
1wqmMiRW4U0mtD531J5KwYU=
=BSMp
-----END PGP SIGNATURE-----

[James Troup (elmo)]

Err, sorry, what? The consistency I care about (and I suspect Scott
too) is that I'm able to use -c with both bzr diff and bzr log. As it
is right now, I find myself typing bzr log -c $whatever _all the time_
and it's very frustrating that it doesn't work. This seems like an
obvious UI bug that's easy to fix?

[Scott James Remnant (Canonical) (canonical-scott)]

Sorry Aaron, I entirely disagree.

Consistency of your implementation is irrelevant, the user will have an expected behaviour in both cases, and that should be upheld.

"bzr merge" and "bzr diff" both take a -c/--change option, which is great. It means "just this change"

"bzr log" should have that too, for consistency. It'd take a single revision id, and show just that log message.

Since there's no "-c" option yet, I don't see what the problem with adding it with specific behaviour is?