Crash when pulling with --no-plugins

Bug #248275 reported by Marnanel Thurman
4
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Undecided
Unassigned

Bug Description

Bazaar crashed attempting to pull from an upstream repository. In #229848 it was said that such crashes should only be reported if they appear with --no-plugins turned on. I tried this, and saw:

Script started on Dydd Sul 13 mis Gorffennaf 2008 21:42:59 EDT
tthurman@haematite:~/gnome-bzr/src/metacity$ bzr pull --no-plugins
Using saved location: bzr+ssh://bzr-playground.gnome.org/bzr/gnome/metacity/trunk/
Server is too old for streaming pull, reconnecting. (Upgrade the server to Bazaar 1.2 to avoid this)

/ [ ] Pull phase 0/2
- [========= ] Pull phase 0/2

bzr: ERROR: bzrlib.errors.KnitCorrupt: Knit text:1@41da6766-de25-0410-b389-9acf47e490d7:trunk: corrupt: line-delta from stream for version svn-v3-trunk0:41da6766-de25-0410-b389-9acf47e490d7:trunk:3789 references missing parent <email address hidden>
Try running "bzr check" on the source repository, and "bzr reconcile" if necessary.

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 834, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 790, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 492, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 652, in run
    possible_transports=possible_transports)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/workingtree.py", line 1570, in pull
    possible_transports=possible_transports)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/branch.py", line 1714, in pull
    run_hooks=run_hooks)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/branch.py", line 1513, in pull
    self.update_revisions(source, stop_revision, overwrite=overwrite)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/branch.py", line 1465, in update_revisions
    self.fetch(other, stop_revision)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/branch.py", line 266, in fetch
    pb=nested_pb)
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 949, in fetch
    return inter.fetch(revision_id=revision_id, pb=pb, find_ghosts=find_ghosts)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 2963, in fetch
    pb=pb, find_ghosts=find_ghosts)
  File "/usr/lib/python2.5/site-packages/bzrlib/fetch.py", line 109, in __init__
    self.__fetch()
  File "/usr/lib/python2.5/site-packages/bzrlib/fetch.py", line 139, in __fetch
    self._fetch_everything_for_search(search, pp)
  File "/usr/lib/python2.5/site-packages/bzrlib/fetch.py", line 418, in _fetch_everything_for_search
    self.to_repository.insert_data_stream(data_stream)
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 860, in insert_data_stream
    (format, data_list, reader_func))
  File "/usr/lib/python2.5/site-packages/bzrlib/knit.py", line 847, in insert_data_stream
    (version_id, parents[0]))
KnitCorrupt: Knit text:1@41da6766-de25-0410-b389-9acf47e490d7:trunk: corrupt: line-delta from stream for version svn-v3-trunk0:41da6766-de25-0410-b389-9acf47e490d7:trunk:3789 references missing parent <email address hidden>
Try running "bzr check" on the source repository, and "bzr reconcile" if necessary.

bzr 1.3.1 on python 2.5.2.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'pull', '--no-plugins']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'cy_GB.UTF-8'
plugins:
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.
/usr/lib/python2.5/site-packages/bzrlib/lockable_files.py:110: UserWarning: file group LockableFiles(<bzrlib.transport.remote.RemoteSSHTransport url=bzr+ssh://bzr-playground.gnome.org/bzr/gnome/metacity/.bzr/repository/>) was not explicitly unlocked
  warn("file group %r was not explicitly unlocked" % self)
tthurman@haematite:~/gnome-bzr/src/metacity$ exit

Script done on Dydd Sul 13 mis Gorffennaf 2008 21:43:28 EDT

bzr versions:
Bazaar (bzr) 1.3.1
  Python interpreter: /usr/bin/python 2.5.2.final.0
  Python standard library: /usr/lib/python2.5
  bzrlib: /usr/lib/python2.5/site-packages/bzrlib

description: updated
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 248275] [NEW] Crash when pulling with --no-plugins

On Mon, 2008-07-14 at 01:46 +0000, Thomas Thurman wrote:
> Public bug reported:
>
> Bazaar crashed attempting to pull from an upstream repository. In
> #229848 it was said that such crashes should only be reported if they
> appear with --no-plugins turned on. I tried this, and saw:

Thanks. There are a couple of bugs here - mainly that the error should
be printed cleanly. I am checking the metacity repository; we did seed
them with rsync from jc2k (well, he rsynced to the playground :)) but
rsync is not transactional :) so its possible it dropped something added
during the copy. If it checks out ok then there will be a second bug,
that you are seeing a corrupt message when nothing is wrong.

Hmm. Its possible you have the aliasing bug, I think it was in 1.3 which
caused files with trailing newlines to error when multi-retrieved (no
data corruption of course - the sha1 check is what triggers :)).

If so, upgrading your bzr to 1.5 should fix this simply. (1.5 is in the
bzr ppa, along with bzrtools and other things, but not yet bzr-svn. So
its probably a little tricky. I mailed the list about bzr-svn yesterday
will be following up today).

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
Robert Collins (lifeless) wrote :

The repository checked out ok; I think you are definitely suffering the
multi-extraction bug, already fixed in 1.5 or so.

Cheers,
Rob

Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 1.5
status: New → Fix Released
Revision history for this message
dikmoet (adikmoet) wrote :

i have 2890 bugs on mij pc i must start it 10 time before it start to work
how can a fixs this big problem a can not update also

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.