lua version detection is wrong

Bug #247164 reported by Oliver Lehmann
2
Affects Status Importance Assigned to Milestone
Ember
Fix Released
High
Erik Ogenvik

Bug Description

the lua detection is wrong:

I've 5.0.3 installed and configure tells me:

checking for LUA... yes
configure: Lua version => 5.1, make sure that CEGUI also has been compiled for this version

this is because the version detection is done by using pkg-config but lua < 5.1 does not install a lua50.pc - so pkg-config does not know anything about lua. Looks like lua 5.1 is the fallback...

lua 5.1 installs its .pc file on FreeBSD by the way as lua-5.1 but I could change this in configure while installing the port.
I'll now try to change configure to fallback to LUA50.

Revision history for this message
Erik Ogenvik (erik-ogenvik) wrote :

If FreeBSD uses lua-5.1 we should add a check for that too, but which version does CEGUI link against?

Changed in ember:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Oliver Lehmann (lehmann-ans-netz) wrote :

CEGUI right now links to 5.0.

ember 0.5.3 just dropped lua 5.0 support it looks like - even if configure claims it supports it

1) src/components/ogre/scripting/luaobject.h includes lua.hpp - this only exists in lua 5.1
2) lua_getfield gets used unconditional but this also exists only in lua 5.1

Seems that I now need to change CEGUI & his friends to use lua 5.1 - I hope no other
CEGUI-using application are going to be broken...
You have not tested 0.5.3 with lua 5.0 have you? :(

Revision history for this message
Erik Ogenvik (erik-ogenvik) wrote :

Ah, damn, sorry about that. Yeah, you are correct; I forgot to test it with Lua 5.0.
We've tried to provide fallbacks for 5.0 but with the new functions it has apparently slipped us by.
Preferrably we would use 5.1 since it contains a lot of nice additions to the language, and all distros now come with 5.1, but if you run into problems with changing CEGUI (i.e. other packages breaking) I can probably whip up a patch for you so Ember can be compiled against 5.0.
Again I'm sorry, it's my fault. I just forgot to test it against 5.0.

Revision history for this message
Oliver Lehmann (lehmann-ans-netz) wrote :

I'll try working on that this weekend - I'll let you know

Revision history for this message
Oliver Lehmann (lehmann-ans-netz) wrote :
Revision history for this message
Erik Ogenvik (erik-ogenvik) wrote :

Alright, I'll leave this bug open until the next release however.
I'm really keen on dropping support for Lua 5.0 since there's some really nice language constructs in 5.1 that we would like to be able to use, and 5.1 has been out for some while now so I guess that most distros support it by default.
One never knows however, so we'll have to see if there are any more troubles with packaging 0.5.3.

Changed in ember:
status: Confirmed → In Progress
Revision history for this message
Erik Ogenvik (erik-ogenvik) wrote :

With the newest version of Ember we've moved to Lua 5.1, dropping support for 5.0. The main reason is that it allows us to use a couple of new language features which are really nice. And in addition we don't have to worry about breaking stuff for 5.0 any more.

Changed in ember:
assignee: nobody → erik-hjortsberg
milestone: none → 0.5.5
status: In Progress → Fix Committed
Changed in ember:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.