Emacs 21 compat bug
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
erc (Ubuntu) |
Expired
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: erc
When loading erc 5.3-1ubuntu1 in Emacs 21, it fails with an error regarding the unknown property 'min-colors'. If it's loaded a second time then it goes through but a lot of faces don't get defined.
This is a compat bug. After fixing it with the following trivial patch, it works just fine in Emacs 21.
--- erc-5.3.orig/erc.el
+++ erc-5.3/erc.el
@@ -1170,7 +1170,9 @@
(defface erc-notice-face
(if (featurep 'xemacs)
'((t (:bold t :foreground "blue")))
- '((((class color) (min-colors 88))
+ `((,(if (< emacs-major-version 22)
+ '((class color))
+ '((class color) (min-colors 88)))
(:bold t :foreground "SlateBlue"))
(t (:bold t :foreground "blue"))))
"ERC face for notices."
Changed in erc (Ubuntu): | |
status: | New → Incomplete |
Martin Stjernholm <email address hidden> writes:
> When loading erc 5.3-1ubuntu1 in Emacs 21, it fails with an error
> regarding the unknown property 'min-colors'. If it's loaded a second
> time then it goes through but a lot of faces don't get defined.
>
> This is a compat bug. After fixing it with the following trivial patch,
> it works just fine in Emacs 21.
A similar fix is in the development version of ERC.
-- mwolson. org/ | Hobbies: Lisp, HCoop | ------- ------- ------- ------- ------- ------- ------- '
| Michael Olson | FSF Associate Member #652 |
| http://
| Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |
`------