/etc/init.d/nvidia-kernel contains bashisms
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
nvidia-kernel-common (Debian) |
Fix Released
|
Unknown
|
|||
nvidia-kernel-common (Ubuntu) |
Invalid
|
High
|
Ben Collins |
Bug Description
Automatically imported from Debian bug report #335976 http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Debian Bug Importer (debzilla) wrote : | #1 |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Debian Bug Importer (debzilla) wrote : | #2 |
Message-ID: <email address hidden>
Date: Wed, 26 Oct 2005 21:10:48 -0700
From: Jamie Heilman <email address hidden>
To: <email address hidden>
Subject: /etc/init.
Package: nvidia-
Version: 20051025+1
Severity: grave
Setting up nvidia-
/etc/init.
invoke-rc.d: initscript nvidia-kernel, action "start" failed.
"for (( expr1 ; expr2 ; expr3 )) ; do list ; done" syntax is a bashism,
instead consider:
--- nvidia-kernel.orig 2005-10-26 20:58:30.000000000 -0700
+++ nvidia-kernel 2005-10-26 21:06:26.000000000 -0700
@@ -6,7 +6,7 @@
[ -r /etc/default/
# test if anything is requested
-if [ -z "$NVIDIA_CARDS" ] || [ "$NVIDIA_CARDS" = 0 ]; then
+if [ -z "$NVIDIA_CARDS" ] || [ "$NVIDIA_CARDS" -lt 1 ]; then
# Nothing to do but exit.
exit 0
fi
@@ -16,8 +16,8 @@
mknod -m 0660 /dev/nvidiactl c 195 255
chgrp video /dev/nvidiactl
fi
- for (( i=0; i < NVIDIA_CARDS && i < 4; i++ )); do
- if ! [ -e /dev/nvidia$i ]; then
+ for i in $(seq 0 $(($NVIDIA_CARDS - 1))); do
+ if ! [ -e /dev/nvidia$i ]; then
mknod -m 0660 /dev/nvidia$i c 195 $i
chgrp video /dev/nvidia$i
fi
--
Jamie Heilman http://
"Paranoia is a disease unto itself, and may I add, the person standing
next to you may not be who they appear to be, so take precaution."
-Sathington Willoughby
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#3 |
Source: nvidia-
Source-Version: 20051026+1
We believe that the bug you reported is fixed in the latest version of
nvidia-
nvidia-
to pool/contrib/
nvidia-
to pool/contrib/
nvidia-
to pool/contrib/
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Randall Donald <email address hidden> (supplier of updated nvidia-
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Wed, 26 Oct 2005 21:47:15 -0700
Source: nvidia-
Binary: nvidia-
Architecture: source all
Version: 20051026+1
Distribution: unstable
Urgency: low
Maintainer: Randall Donald <email address hidden>
Changed-By: Randall Donald <email address hidden>
Description:
nvidia-
Closes: 335976
Changes:
nvidia-
.
* fix bashism in init script (closes: #335976)
Files:
88ce5e3a7d77f1
531510135875c3
6147a257bd9ed2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDYFxrU+
fvyxsWKpyil0rAN
=WJ8j
-----END PGP SIGNATURE-----
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Debian Bug Importer (debzilla) wrote : | #4 |
Message-Id: <email address hidden>
Date: Thu, 27 Oct 2005 01:47:05 -0700
From: Randall Donald <email address hidden>
To: <email address hidden>
Subject: Bug#335976: fixed in nvidia-
Source: nvidia-
Source-Version: 20051026+1
We believe that the bug you reported is fixed in the latest version of
nvidia-
nvidia-
to pool/contrib/
nvidia-
to pool/contrib/
nvidia-
to pool/contrib/
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Randall Donald <email address hidden> (supplier of updated nvidia-
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Wed, 26 Oct 2005 21:47:15 -0700
Source: nvidia-
Binary: nvidia-
Architecture: source all
Version: 20051026+1
Distribution: unstable
Urgency: low
Maintainer: Randall Donald <email address hidden>
Changed-By: Randall Donald <email address hidden>
Description:
nvidia-
Closes: 335976
Changes:
nvidia-
.
* fix bashism in init script (closes: #335976)
Files:
88ce5e3a7d77f1
531510135875c3
6147a257bd9ed2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDYFxrU+
fvyxsWKpyil0rAN
=WJ8j
-----END PGP SIGNATURE-----
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#5 |
New version is still broken. The way 20051026+1 is written, if
NVIDIA_CARDS is 0 then make_nodes is still run, possibly creating
/dev/nvidiactl needlessly. Also, expr in bash apparently lets you get
away with the form of variable expansion you used, but dash does not.
Look at the patch I gave you again, it was correct, and now here's
patch against version 20051026+1:
@@ -6,7 +6,7 @@
[ -r /etc/default/
# test if anything is requested
-if [ -z "$NVIDIA_CARDS" ] || [ "$NVIDIA_CARDS" -lt 0 ]; then
+if [ -z "$NVIDIA_CARDS" ] || [ "$NVIDIA_CARDS" -lt 1 ]; then
# Nothing to do but exit.
exit 0
fi
@@ -16,7 +16,7 @@
mknod -m 0660 /dev/nvidiactl c 195 255
chgrp video /dev/nvidiactl
fi
- for i in $(seq 0 $((NVIDIA_CARDS - 1))); do
+ for i in $(seq 0 $(($NVIDIA_CARDS - 1))); do
if ! [ -e /dev/nvidia$i ]; then
mknod -m 0660 /dev/nvidia$i c 195 $i
chgrp video /dev/nvidia$i
--
Jamie Heilman http://
"Most people wouldn't know music if it came up and bit them on the ass."
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Debian Bug Importer (debzilla) wrote : | #6 |
Message-ID: <email address hidden>
Date: Fri, 28 Oct 2005 18:04:51 -0700
From: Jamie Heilman <email address hidden>
To: <email address hidden>
Cc: <email address hidden>
Subject: Re: /etc/init.
New version is still broken. The way 20051026+1 is written, if
NVIDIA_CARDS is 0 then make_nodes is still run, possibly creating
/dev/nvidiactl needlessly. Also, expr in bash apparently lets you get
away with the form of variable expansion you used, but dash does not.
Look at the patch I gave you again, it was correct, and now here's
patch against version 20051026+1:
@@ -6,7 +6,7 @@
[ -r /etc/default/
# test if anything is requested
-if [ -z "$NVIDIA_CARDS" ] || [ "$NVIDIA_CARDS" -lt 0 ]; then
+if [ -z "$NVIDIA_CARDS" ] || [ "$NVIDIA_CARDS" -lt 1 ]; then
# Nothing to do but exit.
exit 0
fi
@@ -16,7 +16,7 @@
mknod -m 0660 /dev/nvidiactl c 195 255
chgrp video /dev/nvidiactl
fi
- for i in $(seq 0 $((NVIDIA_CARDS - 1))); do
+ for i in $(seq 0 $(($NVIDIA_CARDS - 1))); do
if ! [ -e /dev/nvidia$i ]; then
mknod -m 0660 /dev/nvidia$i c 195 $i
chgrp video /dev/nvidia$i
--
Jamie Heilman http://
"Most people wouldn't know music if it came up and bit them on the ass."
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#7 |
Source: nvidia-
Source-Version: 20051028+1
We believe that the bug you reported is fixed in the latest version of
nvidia-
nvidia-
to pool/contrib/
nvidia-
to pool/contrib/
nvidia-
to pool/contrib/
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Randall Donald <email address hidden> (supplier of updated nvidia-
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Fri, 28 Oct 2005 19:46:20 -0700
Source: nvidia-
Binary: nvidia-
Architecture: source all
Version: 20051028+1
Distribution: unstable
Urgency: low
Maintainer: Randall Donald <email address hidden>
Changed-By: Randall Donald <email address hidden>
Description:
nvidia-
Closes: 335976
Changes:
nvidia-
.
* really fix script (closes: #335976)
Files:
b1c5084ad0e90d
56e9255b2ae232
5c627973caf09c
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDYuL8U+
5XdpJvH6uiy+
=HLkW
-----END PGP SIGNATURE-----
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Debian Bug Importer (debzilla) wrote : | #8 |
Message-Id: <email address hidden>
Date: Fri, 28 Oct 2005 20:02:05 -0700
From: Randall Donald <email address hidden>
To: <email address hidden>
Subject: Bug#335976: fixed in nvidia-
Source: nvidia-
Source-Version: 20051028+1
We believe that the bug you reported is fixed in the latest version of
nvidia-
nvidia-
to pool/contrib/
nvidia-
to pool/contrib/
nvidia-
to pool/contrib/
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Randall Donald <email address hidden> (supplier of updated nvidia-
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Fri, 28 Oct 2005 19:46:20 -0700
Source: nvidia-
Binary: nvidia-
Architecture: source all
Version: 20051028+1
Distribution: unstable
Urgency: low
Maintainer: Randall Donald <email address hidden>
Changed-By: Randall Donald <email address hidden>
Description:
nvidia-
Closes: 335976
Changes:
nvidia-
.
* really fix script (closes: #335976)
Files:
b1c5084ad0e90d
56e9255b2ae232
5c627973caf09c
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDYuL8U+
5XdpJvH6uiy+
=HLkW
-----END PGP SIGNATURE-----
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
|
#9 |
Package: nvidia-
Version: 20051026+1
Followup-For: Bug #335976
the if [ -z "$NVIDIA_CARDS" ] || [ "$NVIDIA_CARDS" -lt 0 ]; then part
wasn't changed...
Now I have /etc/init.
"NVIDIA_CARDS - 1" error.
Could the maintener check its package with dash as sh ?
thanks
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/dash
Kernel: Linux 2.6.13
Locale: LANG=fr_FR@euro, LC_CTYPE=fr_FR@euro (charmap=
Versions of packages nvidia-
ii module-init-tools 3.2-pre9-3 tools for managing Linux kernel mo
ii modutils 2.4.27.0-3 Linux module utilities
Versions of packages nvidia-
ii nvidia-
-- no debconf information
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Debian Bug Importer (debzilla) wrote : | #10 |
Message-Id: <email address hidden>
Date: Sat, 29 Oct 2005 09:44:17 +0200
From: matthieu castet <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: nvidia-
Package: nvidia-
Version: 20051026+1
Followup-For: Bug #335976
the if [ -z "$NVIDIA_CARDS" ] || [ "$NVIDIA_CARDS" -lt 0 ]; then part
wasn't changed...
Now I have /etc/init.
"NVIDIA_CARDS - 1" error.
Could the maintener check its package with dash as sh ?
thanks
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/dash
Kernel: Linux 2.6.13
Locale: LANG=fr_FR@euro, LC_CTYPE=fr_FR@euro (charmap=
Versions of packages nvidia-
ii module-init-tools 3.2-pre9-3 tools for managing Linux kernel mo
ii modutils 2.4.27.0-3 Linux module utilities
Versions of packages nvidia-
ii nvidia-
-- no debconf information
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Ben Collins (ben-collins) wrote : | #11 |
We don't seem to have this script in nvidia-
Automatically imported from Debian bug report #335976 http:// bugs.debian. org/335976