Requests on the Flickr resource provider are not cancellable
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Moovida |
Fix Released
|
High
|
Olivier Tilloy |
Bug Description
The Flickr resource provider in its current state does not implement the cancellation API that allows to have a reactive UI, resulting in weird bugs when browsing Flickr.
Steps to reproduce:
0) Clear your pictures cache in ~/elisa-
1) Launch Elisa
2) Go to Pictures > Internet > Flickr > Last 7 Days Interesting
3) Start a slideshow, and quickly jump to the next image a repeated number of times
4) Notice how the same images seem to be displayed in sequence, instead of the correct ones (and the tracebacks that are logged)
An example traceback is:
Traceback (most recent call last):
File "/home/
modifier.
File "/home/
obj.
File "/home/
len(
File "/home/
self.
File "/home/
cancel_
File "/home/
dfr.cancel()
AttributeError: Deferred instance has no attribute 'cancel'
Changed in elisa: | |
assignee: | nobody → osomon |
importance: | Undecided → High |
milestone: | none → 0.5.1 |
status: | New → Confirmed |
Changed in elisa: | |
milestone: | 0.5.1 → 0.5.2 |
Changed in elisa: | |
milestone: | 0.5.2 → 0.5.1 |
status: | Confirmed → Fix Released |
Actually this impacts all internet services that use the http_client plugin since requests are not cancellable.