Users should be indentified by an ID rather than username

[Greg A]

In the users table, each user should have an ID. Then rather than referencing the username in the admins table the ID can be referenced. This means users could change their usernames.

[David Futcher (bobbo)]

Confirming, this could be useful for some users. Would the site be renamed too?

[Greg A (etulfetulf)]

Yes, I would have thought this would be the main reason for wanting to change username.

[David Futcher (bobbo)]

I'm actually a bit confused by this. Do we need to change the current auth code? From having a quick read of it I dont think we do so this just needs to be a schema change in the admins table so we define admins using ids instead of usernames?

[Greg A (etulfetulf)]

I actually didn't realise when I wrote this that users already had an ID in the users table. So that makes everything easier to implement!

Yes, we need a schema change in the admins table - and is_admin() will have to be adjusted. We might want a getIDfromUsername() as well.

I don't think much (if any) of the other auth code will change.

[David Futcher (bobbo)]

Fix committed in -devel revision 187. is_admin() now looks for user id instead of username, updated the admins table schema.