Unknown D messages are ignored

Bug #245977 reported by Big Muscle
2
Affects Status Importance Assigned to Milestone
DSHub
Confirmed
Medium
Unassigned

Bug Description

ADC protocol says that hub should work with messages according to their types and not real content. If I try to send some unknown message to DSHub (for example DPSR) with target user SID, it's not delivered to this target user. I use same code as for DRES (so it is correctly formatted) where this command is dispatched correctly, but my DPSR isn't.

Changed in dshub:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Pietry (pietry) wrote :

I think I removed the parsing of the unknown messages for security purposes. I haven't decided what to do with these messages yet. I know this is against the protocol ( the main reason this is in the protocol is that older software can still parse new messages right). Probably I will add the feature...
( Also, I think unknown B messages are ignored aswell...)
Thanks for reporting.

Revision history for this message
cologic (cologic) wrote :

I'd like to point out my response to this a while ago at http://dcpp.wordpress.com/2007/07/18/hub-bandwidth-management/ if you haven't seen it.

If you have some other notion of 'security' in mind, I"d be interested in knowing what.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.