push using sftp on win32 gives error if you have a ssh.exe in your path

[Guillaume Boudreau]

If you have a ssh.exe executable in your Windows PATH (say in C:\WINDOWS\), you might get an error when the "bzr push" tries to invoke ssh.exe with the -V option.

For example: I have putty.exe renamed ssh.exe in my C:\WINDOWS\ directory. When I try to bzr push sftp://... I get: PuTTY Command Line Error: Unknown option "-V"
because bzr push executes "ssh -V" to get the SSH version from the Cygwin ssh client, but since I have a ssh.exe in my C:\WINDOWS\ directory, this executable is used instead of the Cygwin ssh.exe executable.
Simply renaming C:\WINDOWS\ssh.exe to C:\WINDOWS\ssh2.exe fixes the problem.

Note that the push will still work; I guess when "ssh -V" returns nothing (or an error), the push can still complete.
It's was just annoying to get a PuTTY error message every time I pushed something.

[Guillaume Boudreau (bougu)]

The Olive GTK client seems affected, and less resilient to this problem. When trying to push using Olive, I get a floating point error and the push fails.

[Mark Hammond (mhammond)]

I think the main problem will be fixed in 1.6 (and might also be solved for you by setting BZR_SSH=plink) The Olive problem sounds unrelated, but I can't be sure.

[Jelmer Vernooij (jelmer)]

the olive problem was a progress bar bug, fixed now.

[John A Meinel (jameinel)]

Setting the environment variable "BZR_SSH" is another valid fix for this.