Add option of starting Smart --gui to ksmarttray

[Rehan Khan]

Imported: http://tracker.labix.org/issue133

Reason: Patch Review

further details: https://blueprints.launchpad.net/smart/+spec/bug-reporting-migration

msg607 (view) Author: sboddy Date: 2006-08-04.17:47:44

Frank, I grabbed the source from subversion, then used some commands I got from
the web to compile the tray app. Then I just moved the old binary and put mine
in it's place. Not proper practice, but it worked for me. You need
kdelibs3-devel installed, then in trunk/contrib/ksmarttray do:

. /etc/opt/kde3/common_options
update_admin
./configure $configkde
do_make

msg606 (view) Author: frank Date: 2006-08-04.17:04:32

Hi sboddy,

I tried to compile the latest version into a Mandriva rpm, but it failed to
compile, even without your patch, so there seems to something wrong with the
SPEC file. Nevertheless, is there someone, who is able to integrate this patch
into the development version of ksmarttray? I think this would make smart even
more userfriendly!

msg605 (view) Author: sboddy Date: 2006-08-03.01:43:23

Frank, this is something I also wanted, but ksmarttray hasn't changed in ages.

So I had a quick hack. Now I haven't done C/C++ since Uni (10+ years) but most
of it is copy and paste. I've tested it, and it works very well for me, so feel
free to try it.

See the diff I'm attaching. Not sure if this needs to be posted elsewhere for
the "Smart guys" to notice it ;-)

msg427 (view) Author: frank Date: 2006-03-12.16:30:36

I would like to have another option besides the check and Quit options in the
ksmarttray context menu:
What about starting the smart --gui command from another menuentry like
"Smart-gui"?

[Rehan Khan (rasker)]

This patch is good. Another alternative would be just to remove the 'upgrade' from 'smart --gui upgrade' and ksmarttray would change from having two methods of checking (single left click and right click menu) to one (right click menu) and single click would start Smart. Thus the tray Icon can start and Check without much change. As this improves the usability I think we should push this into trunk and then release.

[Gustavo Niemeyer (niemeyer)]

This has been merged into the trip-work branch.

[Gustavo Niemeyer (niemeyer)]

The implementation looks *really* nice, specially the idea of
moving getMirrors() to the base channel.

I'm adding some comments below, but it would be fantastic to
get this in place on time for 1.2:

[1]

The existence of MirrorsChannel doesn't seem to be necessary
anymore. Can we remove it?

[2]

This change will blow up any existing caches right after Smart
is upgraded. Talk to me online for hints about how to prevent
it.

[3]

The number of fetch steps will be wrong when there's no mirror file.

[4]

There are no tests for the changes in control.py

[5]

It would be great if the test for the channel was in a Python file
(e.g. metadata.py), specifically for testing the metadata channel,
and if this branch didn't change metadata.txt. The doctest file
was mostly a quick workaroud to get some tests in place, but it's
a poor way to verify incremental changes like this. For instance:
by introducing the test for mirrorlist, you're removing the test
that checks that it works fine *without* this option.

To get some idea for how to build this test file, check
tests/debloader.py, or just talk to me online. I'll be happy
to discuss this with you, or to help you.

[Gustavo Niemeyer (niemeyer)]

Erm, oops.

Please ignore the last comment. It was a review of a different bug.

[Anders F Björklund (afb)]

Released, 2009-03-04