JoinNotAllowed should cause a 400 response when raised on the API layer
Bug #244527 reported by
Guilherme Salgado
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
j.c.sackett | ||
Bug Description
As seen on OOPS-912S73, if someone tries to join a restricted team, they'll get a 500 response, which in turn causes that OOPS to show up in our reports. That exception should cause a 400 response when raised on the webservice layer, since that's something that may happen and should not show up in our OOPS reports as something that needs fixing.
Related branches
lp:~jcsackett/launchpad/join-not-allowed-244527
- Edwin Grubbs (community): Approve (code)
-
Diff: 160 lines (+65/-18)4 files modifiedlib/lp/registry/errors.py (+13/-7)
lib/lp/registry/interfaces/person.py (+0/-5)
lib/lp/registry/model/person.py (+4/-2)
lib/lp/registry/tests/test_team_webservice.py (+48/-4)
| affects: | launchpad-foundations → launchpad-registry |
| Changed in launchpad-registry: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| visibility: | private → public |
| Changed in launchpad-registry: | |
| milestone: | none → 10.11 |
| tags: | added: api |
| tags: | added: trivial |
| Changed in launchpad-registry: | |
| assignee: | nobody → j.c.sackett (jcsackett) |
| Changed in launchpad-registry: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11783 <http://