Launchpad itself

use PublishingTunableLoop in obsolete-distroseries.py and start-rebuild.py

Bug #244328 reported by Celso Providelo
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Jeroen T. Vermeulen
Launchpad itself 11.05

Bug Description

As suggested by Barry in lp-review ML, we should generalize and test PublishingTunableLoop since it could be obviously used in other places in our code tree.

(obsolete-distroseries.py and start-rebuild.py will need it for sure)

Related branches

lp:~jtv/launchpad/db-bug-244328
Graham Binns (community): Approve (code)
Diff: 649 lines (+37/-339)
8 files modified
lib/lp/archivepublisher/deathrow.py (+9/-19)
lib/lp/archivepublisher/domination.py (+1/-15)
lib/lp/archivepublisher/model/ftparchive.py (+6/-15)
lib/lp/archivepublisher/tests/deathrow.txt (+0/-3)
lib/lp/archivepublisher/tests/process-in-batches.txt (+0/-144)
lib/lp/archivepublisher/utils.py (+2/-114)
lib/lp/soyuz/scripts/buildd.py (+4/-7)
lib/lp/soyuz/scripts/publishdistro.py (+15/-22)
Celso Providelo (cprov)
Changed in soyuz:
assignee: nobody → cprov
importance: Undecided → High
milestone: none → 1.99
status: New → Triaged
Julian Edwards (julian-edwards)
Changed in soyuz:
milestone: 1.99 → none
Curtis Hovey (sinzui)
Changed in soyuz:
assignee: Celso Providelo (cprov) → nobody
Revision history for this message
Robert Collins (lifeless) wrote :

Marking low because theres no evidence here that things are suffering without this.

summary: - Generalize and test PublishingTunableLoop
+ use PublishingTunableLoop in obsolete-distroseries.py and start-
+ rebuild.py
Changed in soyuz:
importance: High → Low
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

What suffering there was may well have gone away with memory upgrades and the GenerationalCache. In our current state, we ought to see if we can do without PublishingTunableLoop.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Preparing a branch for this since the explicit cache management may be what's hitting performance of the new publish-ftpmaster script so hard. If a script invoked by publish-ftpmaster invalidates ORM caches, that now affects the entire script run rather than just a subprocess.

Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Jeroen T. Vermeulen (jtv)
milestone: none → 11.05
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in db-stable r10407 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/10407>.

Changed in launchpad:
milestone: 11.05 → 11.04
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Jeroen T. Vermeulen (jtv)
tags: added: qa-ok
removed: qa-needstesting
Ursula Junque (ursinha)
Changed in launchpad:
milestone: 11.04 → 11.05
Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.