[mc 4.6.2] mc-utf8.patch disables visible whitespace feature

[Alexey Borzenkov]

Binary package hint: mc

When I built and installed mc-4.6.2~git20080311 I found that it lacks the feature I love the most: visible tabs and whitespace in the editor. I found that the cause is debian/patches/utf8/mc-utf8.patch, which pretty much removes the heart of the feature (search for visible_tabs and visible_tws handled in case '\t' and case ' ' in file mc/edit/editdraw.c). Is this deliberate or accidental?

The way I see it it doesn't make any sense removing it (it has nothing to do with utf8), so I think it was done accidentally by some maintainer.

Please review and get this feature back! :)

[Alexey Borzenkov (snaury)]

Ah! Yes. Now I see why. Working on a patch.

[Alexey Borzenkov (snaury)]

The patch is completed. Either place it in debian/patches/utf8 and add to the series or merge with mc-utf8.patch. Builds fine on my Ubuntu 8.04 amd64. There's a bug in vte (gnome-terminal) though, which causes cursor to disappear (there's no such bug in xterm or konsole), but here's a patch for vte, see here:

https://savannah.gnu.org/bugs/?13146#comment17

[Alexey Borzenkov (snaury)]

Actually, forget this. This makes cursor disappear in vt consoles, was a pain when I wanted to edit some files with this feature enabled, so I'm not against it.