[win32] gst metadata child process doesn't work

[Benjamin Kampmann]

using gst metadata directly works with upicek (direkt import on the file 'main.py') but it fails with the GstMetadataClient

to reproduce:
1) start Elisa
2) click around in Elisa for a half minute or so
3) quit out of elisa
4) check elisa logs for existance messages like so:
  File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\base.py", line 561, in runUntilCurrent
  File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\_pollingfile.py", line 72, in _pollEvent
  File "C:\Program Files (x86)\Elisa\deps\lib\site-packages\twisted\internet\_dumbwin32proc.py", line 54, in checkWork
  File "C:\Program Files (x86)\Elisa\elisa-plugins\elisa\plugins\gstreamer\gst_metadata.py", line 1242, in processEnded
  File "C:\Program Files (x86)\Elisa\elisa-plugins\elisa\plugins\gstreamer\gst_metadata.py", line 1398, in processEnded
  File "C:\Program Files (x86)\Elisa\elisa-plugins\elisa\plugins\gstreamer\gst_metadata.py", line 1303, in startProcess

exceptions.AssertionError:

  WARN MainThread twisted Jul 03 13:12:19 A twisted traceback occurred. (twisted\internet\defer.py:402)

[Benjamin Kampmann (lightyear)]

The Debug tells me that the Jelly-Ing of the Media URI breaks with twisted 8.1.0.

DEBUG MainThread gst_metadata_client_process_launcher Jun 25 18:28:11 Remote output:
DEBUG MainThread gst_metadata Jun 25 18:28:11 getting metadata {'file_type': None, 'uri': Unpersistable('Unpersistable data: instance of class elisa.core.media_uri.MediaUri deemed insecure'), 'mime_type': None, 'thumbnail': None}, queue length 6 (elisa/plugins/gstreamer/gst_metadata.py:1139)

[Benjamin Kampmann (lightyear)]

so it seems to be linked to #214227

[Florian Boucault (fboucault)]

Will be worked around by using Twisted 2.5 instead of 8.1.

[Florian Boucault (fboucault)]

Change to Twisted 2.5 instead of 8.1 commited.

[yyoyo (lionel.martin)]

Does not work in when elisa is launch by elisa.exe

[Olivier Tilloy (osomon)]

As mentioned by Lionel, the problem only happens when elisa is launched from the executable elisa.exe, not when launched with "python elisa-core\elisa.py".
Here is the traceback we get:

Twisted traceback:
Traceback (most recent call last):
  File "elisa.py", line 114, in start_reactor

  File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\gtk2reactor.py", line 244, in run

  File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\gtk2reactor.py", line 254, in simulate

  File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\base.py", line 381, in iterate

--- <exception caught here> ---
  File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\base.py", line 561, in runUntilCurrent

  File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\_pollingfile.py", line 72, in _pollEvent

  File "C:\Program Files (x86)\Elisa\deps\lib\site-packages\twisted\internet\_dumbwin32proc.py", line 54, in checkWork

  File "C:\Program Files (x86)\Elisa\elisa-plugins\elisa\plugins\gstreamer\gst_metadata.py", line 1242, in processEnded

  File "C:\Program Files (x86)\Elisa\elisa-plugins\elisa\plugins\gstreamer\gst_metadata.py", line 1398, in processEnded

  File "C:\Program Files (x86)\Elisa\elisa-plugins\elisa\plugins\gstreamer\gst_metadata.py", line 1303, in startProcess

exceptions.AssertionError:

WARN MainThread twisted Jul 03 13:12:19 A twisted traceback occurred. (twisted\internet\defer.py:402)

[Gernot (gernot-fluendo)]

Maybe it is a problem in win_set_env.set_runtime_env() in the
mswin32.win_set_env module.
If Elisa is launched from command line, the set_env.bat from dist_deps
is used to setup the environment and the win_set_env module is not
needed, so maybe there is a dependency not setup correctly.

Olivier Tilloy schrieb:
> As mentioned by Lionel, the problem only happens when elisa is launched from the executable elisa.exe, not when launched with "python elisa-core\elisa.py".
> Here is the traceback we get:
>
> Twisted traceback:
> Traceback (most recent call last):
> File "elisa.py", line 114, in start_reactor
>
> File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\gtk2reactor.py", line 244, in run
>
> File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\gtk2reactor.py", line 254, in simulate
>
> File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\base.py", line 381, in iterate
>
> --- <exception caught here> ---
> File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\base.py", line 561, in runUntilCurrent
>
> File "C:\OABuild\distribuable-dependencies\deps\Release\lib\site-packages\twisted\internet\_pollingfile.py", line 72, in _pollEvent
>
> File "C:\Program Files (x86)\Elisa\deps\lib\site-packages\twisted\internet\_dumbwin32proc.py", line 54, in checkWork
>
> File "C:\Program Files (x86)\Elisa\elisa-plugins\elisa\plugins\gstreamer\gst_metadata.py", line 1242, in processEnded
>
> File "C:\Program Files (x86)\Elisa\elisa-plugins\elisa\plugins\gstreamer\gst_metadata.py", line 1398, in processEnded
>
> File "C:\Program Files (x86)\Elisa\elisa-plugins\elisa\plugins\gstreamer\gst_metadata.py", line 1303, in startProcess
>
> exceptions.AssertionError:
>
> WARN MainThread twisted Jul 03 13:12:19 A
> twisted traceback occurred. (twisted\internet\defer.py:402)
>
>

[Olivier Tilloy (osomon)]

The problem was that in the windows installed version elisa is launched from an executable (elisa.exe), and the code assumed the main executable was python.exe, so running the GstMetadata client runner with elisa.exe did not work (it once did but that was a hack that anyway disappeared).
A fix has been submitted for merge: when running the installed version, replace the name of the executable to run by "deps\bin\python.exe".