Music CD art not shown

Bug #242655 reported by Charclo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Entertainer Media Center
Triaged
Medium
Charclo

Bug Description

The cover art of a music CD is not shown in the frontend. This is because I forgot some things when I base64 encoded the artist and album. I made it work again but I'm getting segfaults. I'll have to check where this is coming from before I propose for merging.

Changed in entertainer:
assignee: nobody → charclo-michael
importance: Undecided → Medium
Revision history for this message
Matt Layman (mblayman) wrote :

I knew this was an issue too and I can confirm it. Charclo, it looks like we're using the same base encoding logic in multiple places. Do you think that we can create a method instead of duplicating the code in multiple places?

Changed in entertainer:
status: New → Triaged
Revision history for this message
Charclo (charclo-michael) wrote :

I think it is only necessary in two places. But it might be better to put it in a method in one place like you said. Where do you suggest I place that method? (should it be in a class or not?)

Revision history for this message
Matt Layman (mblayman) wrote :

I think it might make the most sense to be an Album method since the art is directly related to it. Plus, I think the new backend will be storing the album art url directly with the albums (but I'm not totally sure about that).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.