add tales for @@/yes (checkmark) and @@/no (x-mark) images
Bug #240759 reported by
Edwin Grubbs
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Curtis Hovey | ||
Bug Description
Displaying a checkmark or x-mark for boolean fields is very handy, so it should be a tales formatter.
<img src="/@@/yes" tal:condition=
<img src="/@@/no" tal:condition="not: context/active"/>
Related branches
lp:~sinzui/launchpad/all-upstream-links
- Brad Crittenden (community): Approve (code)
-
Diff: 460 lines (+165/-133)9 files modifiedlib/canonical/launchpad/doc/tales.txt (+18/-0)
lib/canonical/launchpad/webapp/tales.py (+11/-0)
lib/lp/app/templates/base-layout-macros.pt (+0/-7)
lib/lp/registry/browser/distroseries.py (+3/-20)
lib/lp/registry/browser/tests/packaging-views.txt (+8/-28)
lib/lp/registry/stories/distroseries/xx-show-distroseries-packaging.txt (+33/-25)
lib/lp/registry/stories/packaging/xx-sourcepackage-packaging.txt (+5/-5)
lib/lp/registry/templates/distroseries-packaging.pt (+80/-34)
lib/lp/registry/templates/sourcepackage-portlet-associations.pt (+7/-14)
| Changed in launchpad: | |
| assignee: | nobody → edwin-grubbs |
Revision history for this message
| Diogo Matsubara (matsubara) wrote | #1 |
| Changed in launchpad: | |
| status: | New → Incomplete |
| Changed in launchpad-foundations: | |
| assignee: | edwin-grubbs → nobody |
| tags: | added: tech-debt |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #2 |
| Changed in launchpad-foundations: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| importance: | Undecided → Low |
| milestone: | none → 10.02 |
| status: | Incomplete → In Progress |
Revision history for this message
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #3 |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
Revision history for this message
| Curtis Hovey (sinzui) wrote Bug 240759 Fix released | #4 |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
| tags: | removed: qa-needstesting |
To post a comment you must log in.
Hi Edwin, can you give an example of where that formatter would be used?