race condition merging dupe account with multiple email addresses

[Diogo Matsubara]

Steps to reproduce:
1. Logged-in as FooBar open: http://launchpad.dev/people/+requestmerge
2. Fill in dupe account: salgado
3. Click Submit, you'll be redirected to: http://launchpad.dev/people/+requestmerge-multiple?dupe=29
4. Open in another tab: http://launchpad.dev/~salgado/+editemails
5. Remove the unconfirmed email address: <email address hidden>
6. Back to the tab of step 3, select both emails @canonical and @ubuntu
7. Click submit
8. OOPS-893EC36

Module canonical.launchpad.browser.peoplemerge, line 300, in processForm
    assert emailaddress in self.dupeemails
AssertionError

In the process of fixing this bug, please make the AssertionError exception value more informative. Something like:
    assert emailaddress in self.dupeemails, "%s not found in %s" % (emailddress.email, [e.email for e in self.dupeemails])

[Curtis Hovey (sinzui)]

The assert is made before the form starts doing work. The assert can be changed to a sanity check that returns early if it is not safe to precede. The step should show a form error to explain why the user needs to reselect the email addresses.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r11624 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11624>.