initrd/initramfs: Step 2 ongoing, ramdisk-tools needs fixing

[Debian Bug Importer]

Automatically imported from Debian bug report #333857 http://bugs.debian.org/333857

[Sven Luther (sven-luther)]

Hello,

I implemented a way to fix this for initrd-tools :

Index: mkinitrd
===================================================================
--- mkinitrd (revision 4448)
+++ mkinitrd (working copy)
@@ -1309,7 +1309,7 @@
 CONFDIR=/etc/mkinitrd
 unset keep croot cmkimage out || :

-while getopts "d:km:o:r:" flag; do
+while getopts "d:km:o:r:-:" flag; do
  case $flag in
  d)
   CONFDIR="$OPTARG"
@@ -1335,6 +1335,16 @@
  r)
   croot=$OPTARG
   ;;
+ -)
+ case ${OPTARG%=*} in
+ supported-host-version)
+ supported_host_version=${OPTARG#*=}
+ ;;
+ supported-target-version)
+ supported_target_version=${OPTARG#*=}
+ ;;
+ esac
+ ;;
  *)
   usage
   ;;
@@ -1342,6 +1352,19 @@
 done
 shift $(($OPTIND - 1))

+if [ "$supported_host_version" ] || [ "$supported_target_version" ]; then
+ if [ "$supported_host_version" ]; then
+ host_upstream_version=${supported_host_version%%-*}
+ fi
+ if [ "$supported_target_version" ]; then
+ target_upstream_version=${supported_target_version%%-*}
+ if dpkg --compare-versions "$target_upstream_version" ge "2.6.13"; then
+ exit 1
+ fi
+ fi
+ exit 0
+fi
+
 if ! [ $out ] || [ $# -gt 1 ]; then
  usage
 fi

which altough it may not be the nicest way, fixes the issue. Notice that the
invocation is :

  ./mkinitrd --supported-target-version=2.6.13-1-powerpc --supported-host-version=2.6.12-1-powerpc

Due to the way getopts is implemented in shell, so i guess this should be the
version to use here.

I will implement this in initrd-tools and initramfs-tools in the debian-kernel
svn, but await for comments before doing an upload, Jonas, i would appreciate
if you would be able to do this for yaird asap too, as i don't speak perl,
which i think is what yaird implements, right ?

Friendly,

Sven Luther

[Sven Luther (sven-luther)]

tags 333856 + pending
tags 333857 + pending
tag 333856 + pending
tag 333857 + pending
thanks

[Debian Bug Importer (debzilla)]

Automatically imported from Debian bug report #333857 http://bugs.debian.org/333857

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Fri, 14 Oct 2005 08:33:12 +0200
From: Sven Luther <email address hidden>
To: <email address hidden>, <email address hidden>
Cc: <email address hidden>
Subject: initrd/initramfs: Step 2 ongoing, ramdisk-tools needs fixing

Package: initrd-tools
Severity: Serious

Hello, ...

This is the second step in the linux-2.6 >=2.6.13 ramdisk-tool resolution
process. As you well know, 2.6.13 dropped devfs, whcih means initrd-tool
cannot be used anymore, and we now have a choice of yaird or initramfs-tools,
to make things nice and all, a proposal was sent to all of you and on
debian-kernel, but only Simon Horman commented :

  http://lists.debian.org/debian-kernel/2005/10/msg00232.html

So, i am now asking that all ramdisk-tool packages which the kernel team will
support implement the two following things :

  1) Provide the linux-ramdisk-tool virtual package.

  2) implement in their mkinitrd-compatible wrapper the two following options :

    --supported-host-version : will return 0 if the version passed as argument
    (for example 2.6.12-1-powerpc) can be used to generate a ramdisk, and 1
    otherwise. This will mostly generally be 1 always for initramfs and
    initrd -tools, not sure about the 2.2 kernel case and such though, and
    some kind of 2.6 version for yaird.

    --supported-target-version : will return 0 if the tool know how to generate
    a ramdisk for the version passed as argument (for example 2.6.13-1-powerpc),
    and 1 otherwise. This will be >=2.6.8 for yaird, >=2.6.12 for
    initramfs-tools, and <2.6.13 for initrd-tools.

Note, i mark those bugs as RC, since this is of primordial importance to get
implemented quickly so that we may move 2.6.13 and beyond to sid in a timely
fashion.

Friendly,

Sven Luther

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Fri, 14 Oct 2005 09:27:27 +0200
From: Sven Luther <email address hidden>
To: <email address hidden>, <email address hidden>,
 <email address hidden>, <email address hidden>
Subject: Example way to solve this for mkinitrd ...

Hello,

I implemented a way to fix this for initrd-tools :

Index: mkinitrd
===================================================================
--- mkinitrd (revision 4448)
+++ mkinitrd (working copy)
@@ -1309,7 +1309,7 @@
 CONFDIR=/etc/mkinitrd
 unset keep croot cmkimage out || :

-while getopts "d:km:o:r:" flag; do
+while getopts "d:km:o:r:-:" flag; do
  case $flag in
  d)
   CONFDIR="$OPTARG"
@@ -1335,6 +1335,16 @@
  r)
   croot=$OPTARG
   ;;
+ -)
+ case ${OPTARG%=*} in
+ supported-host-version)
+ supported_host_version=${OPTARG#*=}
+ ;;
+ supported-target-version)
+ supported_target_version=${OPTARG#*=}
+ ;;
+ esac
+ ;;
  *)
   usage
   ;;
@@ -1342,6 +1352,19 @@
 done
 shift $(($OPTIND - 1))

+if [ "$supported_host_version" ] || [ "$supported_target_version" ]; then
+ if [ "$supported_host_version" ]; then
+ host_upstream_version=${supported_host_version%%-*}
+ fi
+ if [ "$supported_target_version" ]; then
+ target_upstream_version=${supported_target_version%%-*}
+ if dpkg --compare-versions "$target_upstream_version" ge "2.6.13"; then
+ exit 1
+ fi
+ fi
+ exit 0
+fi
+
 if ! [ $out ] || [ $# -gt 1 ]; then
  usage
 fi

which altough it may not be the nicest way, fixes the issue. Notice that the
invocation is :

  ./mkinitrd --supported-target-version=2.6.13-1-powerpc --supported-host-version=2.6.12-1-powerpc

Due to the way getopts is implemented in shell, so i guess this should be the
version to use here.

I will implement this in initrd-tools and initramfs-tools in the debian-kernel
svn, but await for comments before doing an upload, Jonas, i would appreciate
if you would be able to do this for yaird asap too, as i don't speak perl,
which i think is what yaird implements, right ?

Friendly,

Sven Luther

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Fri, 14 Oct 2005 10:01:42 +0200
From: Sven Luther <email address hidden>
To: <email address hidden>
Subject: mark initramfs-tools and intrd-tools bugs as pending now that i fixed them in SVN.

tags 333856 + pending
tags 333857 + pending
tag 333856 + pending
tag 333857 + pending
thanks

[Sven Luther (luther)]

tag 324351 + fixed
tag 329614 + fixed
tag 330446 + fixed
tag 333857 + fixed

quit

This message was generated automatically in response to a
non-maintainer upload. The .changes file follows.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 14 Oct 2005 07:50:57 +0000
Source: initrd-tools
Binary: initrd-tools
Architecture: source all
Version: 0.1.83
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <email address hidden>
Changed-By: Sven Luther <email address hidden>
Description:
 initrd-tools - tools to create initrd image for prepackaged Linux kernel
Closes: 324351 329614 330446 333857
Changes:
 initrd-tools (0.1.83) unstable; urgency=low
 .
   [ Simon Horman ]
   * Clarify naming of scripts that will be run.
     Thanks to Simon Schoar. (Closes: #324351)
   * Make sure that path to output image is always fully qualified,
     else an image with a relative will not end up where requested
     (closes: #329614)
 .
   [ dann frazier ]
   * Don't assume update-modules is available during postrm (closes: #330446)
 .
   [ Sven Luther ]
   * Added --supported-(host|target)-version support for the new post-2.6.13
     ramdisk-tool policy. Added linux-ramdisk-tool virtual package too.
     (Closes: #333857)
Files:
 bb2f5ea3f208f972649dfb5d1cac123e 644 utils optional initrd-tools_0.1.83.dsc
 eff2ad61dc7e18f607d541bd71a53dac 28815 utils optional initrd-tools_0.1.83.tar.gz
 dc7b11f6eb3cc3cf934c6639f1a1db3d 31728 utils optional initrd-tools_0.1.83_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDUs2o2WTeT3CRQaQRAhifAJ9jQVG+GwyAs7lGMD/dwllcAN/GmACfSEAA
igkOcTRK7n9s9dQdA/xC2ew=
=7/gM
-----END PGP SIGNATURE-----

[Debian Bug Importer (debzilla)]

Message-Id: <email address hidden>
Date: Sun, 16 Oct 2005 15:17:06 -0700
From: Sven Luther <email address hidden>
To: <email address hidden>
Cc: Sven Luther <email address hidden>, Debian kernel team <email address hidden>
Subject: Fixed in NMU of initrd-tools 0.1.83

tag 324351 + fixed
tag 329614 + fixed
tag 330446 + fixed
tag 333857 + fixed

quit

This message was generated automatically in response to a
non-maintainer upload. The .changes file follows.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 14 Oct 2005 07:50:57 +0000
Source: initrd-tools
Binary: initrd-tools
Architecture: source all
Version: 0.1.83
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <email address hidden>
Changed-By: Sven Luther <email address hidden>
Description:
 initrd-tools - tools to create initrd image for prepackaged Linux kernel
Closes: 324351 329614 330446 333857
Changes:
 initrd-tools (0.1.83) unstable; urgency=low
 .
   [ Simon Horman ]
   * Clarify naming of scripts that will be run.
     Thanks to Simon Schoar. (Closes: #324351)
   * Make sure that path to output image is always fully qualified,
     else an image with a relative will not end up where requested
     (closes: #329614)
 .
   [ dann frazier ]
   * Don't assume update-modules is available during postrm (closes: #330446)
 .
   [ Sven Luther ]
   * Added --supported-(host|target)-version support for the new post-2.6.13
     ramdisk-tool policy. Added linux-ramdisk-tool virtual package too.
     (Closes: #333857)
Files:
 bb2f5ea3f208f972649dfb5d1cac123e 644 utils optional initrd-tools_0.1.83.dsc
 eff2ad61dc7e18f607d541bd71a53dac 28815 utils optional initrd-tools_0.1.83.tar.gz
 dc7b11f6eb3cc3cf934c6639f1a1db3d 31728 utils optional initrd-tools_0.1.83_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDUs2o2WTeT3CRQaQRAhifAJ9jQVG+GwyAs7lGMD/dwllcAN/GmACfSEAA
igkOcTRK7n9s9dQdA/xC2ew=
=7/gM
-----END PGP SIGNATURE-----

[Simon Horman (horms)]

On Sun, Oct 16, 2005 at 03:17:06PM -0700, Sven Luther wrote:
> tag 324351 + fixed
> tag 329614 + fixed
> tag 330446 + fixed
> tag 333857 + fixed
>
> quit
>
> This message was generated automatically in response to a
> non-maintainer upload. The .changes file follows.

For anyone who cares, this was not really an NMU, other
than in the technical sense. It was made by Sven, who
is a member of the Kernel Team, who maintains initrd-tools.

I have added him and myself as uploaders to avoid any future
confusion regarding uploads of initrd-tools made by Sven
(or myself).

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Format: 1.7
> Date: Fri, 14 Oct 2005 07:50:57 +0000
> Source: initrd-tools
> Binary: initrd-tools
> Architecture: source all
> Version: 0.1.83
> Distribution: unstable
> Urgency: low
> Maintainer: Debian kernel team <email address hidden>
> Changed-By: Sven Luther <email address hidden>
> Description:
> initrd-tools - tools to create initrd image for prepackaged Linux kernel
> Closes: 324351 329614 330446 333857
> Changes:
> initrd-tools (0.1.83) unstable; urgency=low
> .
> [ Simon Horman ]
> * Clarify naming of scripts that will be run.
> Thanks to Simon Schoar. (Closes: #324351)
> * Make sure that path to output image is always fully qualified,
> else an image with a relative will not end up where requested
> (closes: #329614)
> .
> [ dann frazier ]
> * Don't assume update-modules is available during postrm (closes: #330446)
> .
> [ Sven Luther ]
> * Added --supported-(host|target)-version support for the new post-2.6.13
> ramdisk-tool policy. Added linux-ramdisk-tool virtual package too.
> (Closes: #333857)
> Files:
> bb2f5ea3f208f972649dfb5d1cac123e 644 utils optional initrd-tools_0.1.83.dsc
> eff2ad61dc7e18f607d541bd71a53dac 28815 utils optional initrd-tools_0.1.83.tar.gz
> dc7b11f6eb3cc3cf934c6639f1a1db3d 31728 utils optional initrd-tools_0.1.83_all.deb
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (GNU/Linux)
>
> iD8DBQFDUs2o2WTeT3CRQaQRAhifAJ9jQVG+GwyAs7lGMD/dwllcAN/GmACfSEAA
> igkOcTRK7n9s9dQdA/xC2ew=
> =7/gM
> -----END PGP SIGNATURE-----

--
Horms

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Mon, 17 Oct 2005 12:23:08 +0900
From: Horms <email address hidden>
To: Debian kernel team <email address hidden>
Cc: <email address hidden>, <email address hidden>,
 <email address hidden>, <email address hidden>
Subject: Re: Fixed in NMU of initrd-tools 0.1.83

On Sun, Oct 16, 2005 at 03:17:06PM -0700, Sven Luther wrote:
> tag 324351 + fixed
> tag 329614 + fixed
> tag 330446 + fixed
> tag 333857 + fixed
>
> quit
>
> This message was generated automatically in response to a
> non-maintainer upload. The .changes file follows.

For anyone who cares, this was not really an NMU, other
than in the technical sense. It was made by Sven, who
is a member of the Kernel Team, who maintains initrd-tools.

I have added him and myself as uploaders to avoid any future
confusion regarding uploads of initrd-tools made by Sven
(or myself).

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Format: 1.7
> Date: Fri, 14 Oct 2005 07:50:57 +0000
> Source: initrd-tools
> Binary: initrd-tools
> Architecture: source all
> Version: 0.1.83
> Distribution: unstable
> Urgency: low
> Maintainer: Debian kernel team <email address hidden>
> Changed-By: Sven Luther <email address hidden>
> Description:
> initrd-tools - tools to create initrd image for prepackaged Linux kernel
> Closes: 324351 329614 330446 333857
> Changes:
> initrd-tools (0.1.83) unstable; urgency=low
> .
> [ Simon Horman ]
> * Clarify naming of scripts that will be run.
> Thanks to Simon Schoar. (Closes: #324351)
> * Make sure that path to output image is always fully qualified,
> else an image with a relative will not end up where requested
> (closes: #329614)
> .
> [ dann frazier ]
> * Don't assume update-modules is available during postrm (closes: #330446)
> .
> [ Sven Luther ]
> * Added --supported-(host|target)-version support for the new post-2.6.13
> ramdisk-tool policy. Added linux-ramdisk-tool virtual package too.
> (Closes: #333857)
> Files:
> bb2f5ea3f208f972649dfb5d1cac123e 644 utils optional initrd-tools_0.1.83.dsc
> eff2ad61dc7e18f607d541bd71a53dac 28815 utils optional initrd-tools_0.1.83.tar.gz
> dc7b11f6eb3cc3cf934c6639f1a1db3d 31728 utils optional initrd-tools_0.1.83_all.deb
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (GNU/Linux)
>
> iD8DBQFDUs2o2WTeT3CRQaQRAhifAJ9jQVG+GwyAs7lGMD/dwllcAN/GmACfSEAA
> igkOcTRK7n9s9dQdA/xC2ew=
> =7/gM
> -----END PGP SIGNATURE-----

--
Horms

[Jeff Bailey (jbailey)]

Marking this as NOTWARTY. We have standized on initramfs-tools.

[Adam D. Barratt (debian-bts-adam-barratt)]

# Hi,
#
# These bugs were fixed in an NMU, but have not been acknowledged by the
# maintainers. With version tracking in the Debian BTS, it is important
# to know which version of a package fixes each bug so that they can be
# tracked for release status, so I'm closing these bugs with the
#relevant version information now

close 271427 8.14+v8.11+urw-0.1
close 314698 0.35-2.1
close 325635 0.35-2.1
close 328017 0.35-2.1
close 320115 2.0-4.2
close 320284 1.11
close 320899 11.4.1870-7.1
close 327078 11.4.1870-7.1
close 327349 11.4.1870-7.1
close 320903 1:0.71-1.2
close 327946 1:0.71-1.2
close 320941 2.0.3-1.1
close 321126 2.6.3.2
close 321545 0.1.3b-1.1
close 341341 0.1.3b-1.1
close 321553 0.1.12-2.2
close 321644 2:1.7.12-1.1
close 346013 2:1.7.12-1.1
close 321816 2.61-2.1
close 321967 4.0.0-2.1
close 330024 4.0.0-2.1
close 321998 0.9.21-0.1
close 322583 0.3.8.1-4
close 322853 0.7.1-3.1
close 356739 0.7.1-3.1
close 322961 0.4.3.1.dfsg-0.1
close 322972 9.4.2-2.4
close 323084 0.4.5+cvs20030824-1.4
close 323160 0.1.10-0.1
close 323355 1.2.11-0.2
close 323725 0.18.2-10.1
close 323942 0.4.0-4.1
close 324371 4.3-18.1
close 324553 2.9.5.0.37.5.2
close 324558 1.2-release-2.1
close 324579 1.11-6.2
close 324606 1.2-release-2.2
close 324908 0.12.4-4.1
close 325210 2.6.0-1.1
close 325490 0.7.1-1.1
close 325514 0.8.6-1.1
close 326468 0.8.6-1.1
close 325532 2:1.7.12-1
close 327366 2:1.7.12-1
close 329778 2:1.7.12-1
close 332480 2:1.7.12-1
close 325635 0.35-2.1
close 328017 0.35-2.1
close 325835 0.1.12-7.1
close 325851 2:1.7.8-1sarge2
close 325938 0.9.8beta2-4.1
close 327930 0.9.8beta2-4.1
close 326285 0.99.3-5.1
close 326295 0.8.2-5.1
close 373110 0.8.2-5.1
close 379331 0.8.2-5.1
close 379334 0.8.2-5.1
close 326298 0.2.12-2.1
close 326311 0.3.5-1pre1.1
close 326355 2.1.8-2.1
close 326362 0.6-7.2
close 326371 0.90beta1-10.1
close 326372 1.0-0.1
close 326378 0.1.17-4.3
close 326466 6.3.2-2.1
close 347129 6.3.2-2.1
close 347205 6.3.2-2.1
close 326489 0.3.7-2.1
close 326756 1.0.9-1.1
close 365518 1.0.9-1.1
close 327429 1.2-1.1
close 350429 1.2-1.1
close 327911 2.3.5-1.1
close 327718 0.6.0-8.2
close 327933 0.9.2-1.1
close 327936 0.8.5-1.1
close 327970 0.5.1-2.1
close 327984 1.3-2.1
close 327986 0.2.36-4.1
close 291328 0.2.36-4.1
close 327996 1.0-1.1
close 328002 1.0.0-9.1
close 328018 2.1.3-2.1
close 328039 1.18A-2.1
close 328172 1.002-0.2
close 328333 4.1.2-1.1
close 328334 1.34-7.1
close 328335 0.8.2-2.1
close 328352 0.13-3.1
close 328364 0.4.0-test5-2.1
close 329467 1.3.1
close 330446 0.1.83
close 333857 0.1.83
close 330666 6:6.2.4.5-0.2
close 330938 0.5.1-2.2

[Adam D. Barratt (debian-bts-adam-barratt)]

# Hi,
#
# These bugs were fixed in an NMU, but have not been acknowledged by the
# maintainers. With version tracking in the Debian BTS, it is important
# to know which version of a package fixes each bug so that they can be
# tracked for release status, so I'm closing these bugs with the
#relevant version information now

close 331601 0.11.3-1.3
close 331607 0.11.3-1.3
close 332216 2005.08.R1-1.1
close 332237 0.11.3-1.4
close 332389 3.1.2-0.1
close 332424 2.6.1-6sarge1
close 325490 0.7.1-1.1
close 332451 0.7.1-1.1
close 332507 0.4.5+cvs20030824-1.5
close 332702 1.5-2.1
close 332703 2.1.19-1.7
close 332808 2.0.12-1.5
close 332896 2.6.2.pre2-1.1
close 333035 0.12-8.1
close 342420 0.12-8.1
close 333046 2.2-5.1
close 333460 1.0-23.2
close 333857 1.0-23.2
close 333885 1.0.20040603-1.1
close 340743 1.0.20040603-1.1
close 334252 20031130-2.1
close 334320 1.4.2-5.1
close 334651 3.0-4.1
close 335126 0.5.3-1.1
close 335144 3.1.1-4.1
close 335146 0.2-1.1
close 335252 0.4.0-1.1
close 335274 0.13-3.2
close 335567 0.4.5+cvs20030824-1.6
close 335719 3.0.cvs20050714-1.1
close 335842 3.10-1.1
close 336168 1.4-2.1
close 336312 0.2.4-4.1
close 336485 2.1.19.dfsg1-0.3
close 379846 2.1.19.dfsg1-0.3
close 336535 2005.08.R1-1.2
close 336710 1:3.2.6-2.1
close 337246 1.0.1-6.1
close 337453 0.9b3-2.1
close 337495 2.09-2sarge1
close 337576 20.0-1.1
close 337593 1.1.3-5.1
close 339192 1.1.3-5.1
close 346695 1.1.3-5.1
close 347154 1.1.3-5.1
close 337708 1.20-2.1
close 337711 0.5-0.2
close 338327 1.9-11.1
close 340076 1.9-11.1
close 345223 1.9-11.1
close 338370 1.35-4.1
close 338432 2.3.3-6.2
close 338483 0.95-1.3
close 338537 1.6-1.1
close 338920 46-2.1
close 339024 4.2.24-1.1
close 341234 4.2.24-1.1
close 339073 1.5.19-20+sarge1
close 339103 0.5.0-1.1
close 339187 6:6.2.4.5-0.3
close 339220 0.6.5-2
close 339225 1.0.4-1.2
close 339226 2.6.1-2.2
close 339236 2.6.2.pre2-1.2
close 339241 1.2.2-4.1
close 339250 6.4-1.1
close 339267 4.2.0-8.1
close 339268 0.7.2-1.1
close 339280 0.1.5.9+cvs.2004.02.07-3.3
close 339711 2.0pl5-19.4
close 339806 0.8pre1-6.1
close 339835 2.11b-1.4
close 340010 1.3-2.2
close 340084 1:1.2.3-9.1
close 340163 0.2.9-5.1
close 340174 0.99.44-0.1
close 340516 1.1.6-2.1
close 340577 1.1.0.20050815-2.1
close 341011 1.8-1.1
close 341975 0.70.1-1.1
close 342035 0.70.1-1.1
close 342322 9.4.2-2.5
close 346188 9.4.2-2.5
close 347153 9.4.2-2.5
close 343035 0.3b.19990815-3.1
close 343771 4.3.9-2.1
close 343782 1.3.13.1-4.1
close 343795 0.5.8-0.1
close 343804 0.3.7-4.1
close 343912 0.0.4-2.1
close 343989 8.4.11-1.1
close 344029 2.1-5.1
close 344254 2.0.9-3.2
close 344447 0.79-3.1
close 344503 9.4.2-2.7
close 345737 2.1.19-1.8
close 345880 2.1.19-1.8
close 344742 0.1.14-1.1