running test suite pollutes current working dir

[Vincent Ladeuil]

Namely, each time I run 'bzr selftest', I end up with the following empty files:

.bzr.log
help.xx
singleCommand.xx

running
   'bzr selftest -s bzrlib.plugins.usertest'
also exhibits the bug

[Ian Clatworthy (ian-clatworthy)]

Just some lazy coding from me some time ago that needs fixing.

[Vincent Ladeuil (vila)]

Ran into it again.

The fix is trivial :

=== modified file 'tests/test_script.py'
--- tests/test_script.py 2008-02-06 06:55:50 +0000
+++ tests/test_script.py 2008-10-01 15:59:41 +0000
@@ -18,7 +18,7 @@
 import random
 import string

-from bzrlib.tests import TestCase
+from bzrlib.tests import TestCaseInTempDir

 from bzrlib.plugins.usertest import (
     toolprofiler,
@@ -28,7 +28,7 @@
     )

-class TestScriptTask(TestCase):
+class TestScriptTask(TestCaseInTempDir):

     def test_compile(self):
         task = userscript.ScriptTask()

In fact, it wasn't lazy coding on your part, bzrlib.test.TestCase really set HOME as os.getcwd() but all our tests relies on TestCaseInTempDir to clean after themselves.

I can't push to lp:bzr-usertest though.

[Martin Pool (mbp)]

On Thu, Oct 2, 2008 at 2:40 AM, vila <email address hidden> wrote:
> Ran into it again.

Well done for fixing it.

> -class TestScriptTask(TestCase):
> +class TestScriptTask(TestCaseInTempDir):
>
> def test_compile(self):
> task = userscript.ScriptTask()
>
>
> In fact, it wasn't lazy coding on your part, bzrlib.test.TestCase really set HOME as os.getcwd() but all our tests relies on TestCaseInTempDir to clean after themselves.

I think this is kind of a bug in TestCase too...

> I can't push to lp:bzr-usertest though.

I've changed the trunk for that plugin to be owned by ~bzr of which
you are a member, so you should be able to do it now.

--
Martin <http://launchpad.net/~mbp/>