"All source" file filter doesn't actually include all source files

[Julien Duponchelle]

In the file open dialog "All source" doesn't include php, css, or js files, which should be considered source files.

To fix it you need add ";*.php;*.css;*.js" to /usr/share/scite/SciTEGlobal.properties at line (265 on mine):
source.files=*.asm;*.c;*.cc;*.cpp;*.cxx;*.cs;*.h;*.hh;*.hxx;*.hpp;\
*.idl;*.odl;*.rc;*.rc2;*.dlg;*.def;\
*.vb;*.vbs;*.bas;*.frm;*.cls;*.ctl;\
*.java;*.js;*.py;*.pl;*.rb;*.cgi;*.lua;*.conf;\
make*;*.mak;\
*.properties;*.html;*.xml;*.iface;*.bat;*.e;*.php;*.css;*.js

[Michael Rooney (mrooney)]

Thanks for your bug report Julien, and for identifying the exact issue and the fix needed. I am marking as triaged as it should be ready for devs.

[Michael Rooney (mrooney)]

Actually after reading the comment above those lines, this may be Invalid:

# The open.filter setting is only used on Windows where the file selector has a menu of filters to apply
# to the types of files seen when opening.
# There is a limit (possibly 256 characters) to the length of a filter,
# so not all source extensions can be in this setting.

I don't know why it says it is only used on Windows as it is used on Linux too (I imagine everywhere), but they seem to knowingly acknowledge that not all file types can be there. However I notice the use of "possibly" when referring to the exact character limit, so maybe it is actually larger and can include more files.

Either way if we are running into a limit maybe more logical choices can be made by popularity. For example I don't know what .hxx or .iface is, while PHP/CSS/JS seem rather popular. If they can't be added due to a limit, maybe they can be swapped for something else.

[Jeff Stone (stone1343)]

This is working as designed. It's pretty much impossible for the SciTE people to keep track of all source types, this is designed to be fairly easily customized by the user. You change it as desired, based on the source types you use.