autoderive should not happen in save-for-later

Bug #237399 reported by danh
2
Affects Status Importance Assigned to Milestone
Microfilm
New
Undecided
Unassigned

Bug Description

There's a report that if you do a save-for-later for a newspaper in the open book factory then a derive kicks off.

Looking at the code in RePublisher-checkin.php that seems quite possible.

So need to modify the code so that save-for-later does not kick off a derive.

Revision history for this message
danh (danh-archive) wrote :

The bug happens because we didn't check the script variable $saveForLater
before queueing up a derive task. So now we check that variable as part
of deciding whether to queue up a derive task:
petabox/www/datanode/RePublisher/RePublisher-checkin.php

We also modified
petabox/www/petabox/OpenBookFactory/index.php
by making the re-checkout query read:
$sql = "SELECT identifier,operator FROM metadata WHERE repub_state=3 and (collection='microfilmreel' or collection='microfilmreel;newspapers') and contributor='$library' ORDER BY operator";

It used to be that the collection test was only
    collection='microfilmreel'

We made this change so that if you do actually save a newspaper for later, you
can actually try to edit it later (after touching any date fields the collection gets
changed to 'microfilmreel;newspapers').

(If any fix reveals further associated problems please append them, or pointers
to them.)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.