Too much redundancy in xx-branch-merge-proposals

Bug #235398 reported by Paul Hummer
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Paul Hummer

Bug Description

After a significant amount of work in the test, Tim and I have noticed that there is a lot of redundancy in the xx-branch-merge-proposals test. It needs to be re-worked in the next cycle

Paul Hummer (rockstar)
Changed in launchpad-bazaar:
assignee: nobody → rockstar
milestone: none → 1.2.6
Changed in launchpad-bazaar:
status: New → Confirmed
Tim Penhey (thumper)
Changed in launchpad-bazaar:
milestone: 1.2.6 → 1.99
status: Confirmed → In Progress
Tim Penhey (thumper)
Changed in launchpad-bazaar:
milestone: 1.99 → 2.1.8
Revision history for this message
Paul Hummer (rockstar) wrote :

The best thing to do in this case is to remove redundant tests, and then modularize the other tests. For instance, the merge queues tests should really be their own set of tests. They may, in fact, require some of the same functionality as branch merge proposals, but that functionality can really be duplicated without having to test its functionality, so it's minimal.

This, in the end, has been what I've decided needs to be done.

Revision history for this message
Paul Hummer (rockstar) wrote :

I've pulled out the merge queue stuff into its own test, and removed redundant tests. I have it in a branch currently, and am awaiting its review.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Moving to 2.1.9

Changed in launchpad-bazaar:
milestone: 2.1.8 → 2.1.9
Paul Hummer (rockstar)
Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Paul Hummer (rockstar)
Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.