Invalid cards allowed to be played

[matt felser]

Binary package hint: gnome-hearts

The game_is_valid_card() function, which returns a boolean, is called incorrectly somewhere, allowing invalid cards to be used.

To reproduce:
Immediately after receiving 3 cards from another player, hover your mouse over any card. This card should be highlighted, signifying that it may be played. Click once to start the game. If you click again, you will play the card that your mouse is over, regardless of whether it may be played following the rules of Hearts.

Alternately:
After playing a card, hover your mouse over any other card that was playable on that trick. Click to move onto the next trick. If you click again, you will play the card that your mouse is over, regardless of whether it may be played following the rules of Hearts.

[matt felser (mfelser)]

After playing around with this glitch for a while, I ended up crashing the program. The output is below.

Traceback (most recent call last):
  File "/usr/share/gnome-hearts/stock_ai.py", line 95, in play_card
    return valid_cards[0]
IndexError: list index out of range
Error in sys.excepthook:
Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/apport_python_hook.py", line 71, in apport_excepthook
    pr['PythonArgs'] = '%r' % sys.argv
AttributeError: 'module' object has no attribute 'argv'

Original exception was:
Traceback (most recent call last):
  File "/usr/share/gnome-hearts/stock_ai.py", line 95, in play_card
    return valid_cards[0]
IndexError: list index out of range

** ERROR **: file player.c: line 120 (player_play): should not be reached
aborting...
Aborted

[Andrew Starr-Bochicchio (andrewsomething)]

From upstream bug:

"I've fixed the bug in the subversion trunk with r187.
Gnome-hearts-0.2.2 is isn't too far away and it will include this fix.

Apparently, when you move the mouse while you click, it's possible to click on
a different card than the (valid) card that is highlighted. The game now checks
the card for validity and will ignore the click if the card is invalid.

Kind regards,

--
Sander Marechal"

[Alessio Treglia (quadrispro)]

New version available in intrepid should fix this bug.