Non photo files can be added to wallpaper list

Bug #234231 reported by cathyli
2
Affects Status Importance Assigned to Milestone
Moblin Applets
Triaged
Medium
ToddBrandt

Bug Description

Description:
----------------
Non photo files can be added to wallpaper list.Found the issue in moblin-applets 0.64-0ubuntu1.

Reproduced steps:
----------------
1. Copy some photos and non photos files to /home/ume/media/photo/.
2. Launch Desktop background from "Preferences" category.

Current result:
----------------
In step2, non photo files were added to wallpaper list, fortunately, these files don't take effect when try to select them.

Expect result:
----------------
In step2, non photo files should not be added to wallpaper list, it should filter non photos files when adding to wallpaper.

cathyli (cathy-li)
Changed in moblin-applets:
assignee: nobody → todd-e-brandt
importance: Undecided → Medium
Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

Do you mean that the file extensions weren't image extensions or that the were properly named image files with non-image data inside them?

Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

Oh man, ok nevermind, I've confirmed the error. IT seems to pull in everything despite the filter I added.

Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

Ok, the problem was in the filter, it was a dumb little programming mistake. It now filters on these types (like it should have all along):

        ".jpg",
        ".jpeg",
        ".gif",
        ".png",
        ".bmp",

Changed in moblin-applets:
status: New → Fix Committed
Revision history for this message
cathyli (cathy-li) wrote :

Hi, todd
I verified the issue in moblin-applets 0.66-0ubuntu5, here is the result:
1. Non photo files with extension name other than ".jpg", ".jpeg", ".gif", ".png", ".bmp" can not be added into wallpaper list, it's correct and the issue is fixed.
2. Fake photo files (non photo files with extension name ".jpg", ".jpeg", ".gif", ".png", ".bmp") can be added into wallpaper list, it's wrong behavior, it should be fixed.
E.g. change a file test.txt to test.bmp, the file be added into wallpaper, and shows "Thumbnail loading..." under the file in the wallpaper list.
3. Photo files with extension name other than ".jpg", ".jpeg", ".gif", ".png", ".bmp" or without extension can not be added into wallpaper list, it's still wrong behavior, it should be fixed. For this issue, I file a new bug #235382.

Changed in moblin-applets:
status: Fix Committed → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.