Distorted audio when increasing volume

Bug #233779 reported by Thomas Vander Stichele
2
Affects Status Importance Assigned to Milestone
Moovida
Fix Released
High
Florian Boucault

Bug Description

I have been checking my audio setup for the last hour trying to figure out where the hell the distortion was coming from - clearly it was clipping digitally, but I had no idea where.

Finally I realized that it was Elisa. I must have accidentally increased the volume in the audio player, which was what was causing the distortion. The GUI indicates the volume at half the full volume!

This is a very bad way of handling volume in Elisa.

If the only thing you have is a volume bar, then 100% should correspond to 1.0 on the volume element or iface, but not more.

If you really do want people to be able to go higher than 1.0 (and thus risk introducing distortion), the volume bar should show this as going past some point of distortion (graying it out or whatever).

Even better would be for the volume bar to have a level indicator below it, that is live updated (much like flumotion has), so you actually see what the effect is of increasing the volume setting.

Tags: player

Related branches

Changed in elisa:
assignee: Kaleo (fboucault) → nobody
Revision history for this message
Olivier Tilloy (osomon) wrote :

In elisa-plugins/elisa/plugins/poblesec/player_video.py, line 497:

    self.volume_max = 2.0

That will generate distortion for sure.
The question is: is there any good reason to set the maximum volume to more than 1.0 ?

Changed in elisa:
importance: Undecided → High
status: New → Confirmed
summary: - elisa distorts audio too easily
+ Distorted audio when increasing volume
Revision history for this message
Florian Boucault (fboucault) wrote :

No, never, ever, let, the, user, do, that.

Thomas is entirely right.

Changed in elisa:
milestone: none → bug-fixing-day
Olivier Tilloy (osomon)
tags: added: player
Changed in elisa:
assignee: nobody → Kaleo (fboucault)
status: Confirmed → In Progress
Revision history for this message
Florian Boucault (fboucault) wrote :

Patch sent for review:

https://www.moovida.com/quality/review/request/%<email address hidden>%3E

Changed in elisa:
status: In Progress → Fix Committed
Olivier Tilloy (osomon)
Changed in elisa:
milestone: bug-fixing-day → 1.0.8
Olivier Tilloy (osomon)
Changed in moovida:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.