Filelist got from search results does not positioned

Bug #231447 reported by eMTee
20
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Medium
Unassigned

Bug Description

With bzr1233, right-clicking on a user in search results and getting/browsing their file list it doesnt take you to the folder/file in their list after it opens. It works with 0.706. (Bug found by bsod)

Changed in dcplusplus:
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
poy (poy) wrote :

the fix was to add the last argument in the call:
WinUtil::addUserItems(menu, users.users, getParent(), si ? Text::fromT(si->getText(COLUMN_PATH)) : "");

i would assume this doesn't work well with multiple selections, no?

Revision history for this message
Jacek Sieka (arnetheduck) wrote :

It takes the first selected file I hope...unless you have some better idea

Revision history for this message
poy (poy) wrote :

here is a solution that tries to take care of multiple selections, using a StringList to store paths when they are added to the users list.
also, removed a bool in addUser since it was redundant with other checks already done in that function.

i'm not sure i got it all right, but it worked in the brief test i did...

poy (poy)
Changed in dcplusplus:
status: Fix Committed → In Progress
Revision history for this message
Jacek Sieka (arnetheduck) wrote :

ok, applied, but please check since there were conflicts with the bitmap vs icon change

Changed in dcplusplus:
status: In Progress → Fix Committed
MikeJJ (mrmikejj)
Changed in dcplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.