Endianess problem in linux/*

[Laurent Bigonville]

Hi,

Under breezy if I try to create a sit tunnel I get "ioctl: Invalid argument".
There was no problem under hoary.

[Laurent Bigonville (bigon)]

the command I use is "ip tunnel add sixxs mode sit"

[Guillaume Desmottes (cassidy)]

Have no error on i386

[Matt Zimmerman (mdz)]

Works fine here as well. Run it under strace and attach the output.

[Laurent Bigonville (bigon)]

Created an attachment (id=4363)
strace

here the strace output

[Laurent Bigonville (bigon)]

I have to mention that I am under powerpc

[Matt Zimmerman (mdz)]

Does anything appear in dmesg when this happens?

[Laurent Bigonville (bigon)]

(In reply to comment #6)
> Does anything appear in dmesg when this happens?

nope

[Laurent Bigonville (bigon)]

In fact there is the same problem with gre and ipip tunnels

[Laurent Bigonville (bigon)]

If I install the hoary version of iproute (20041019-1) no more problem...

[Laurent Bigonville (bigon)]

Same problem with the dapper version(20041019-4ubuntu1)...

Could someone confirm this bug, this is a functionality loss on ppc

[Laurent Bigonville (bigon)]

It's very very strange....

1°I take the binary package for powerpc on the debian archive
(version:20041019-3) and install it, "ip tunnel add plop mode sit" makes no error
2°I download the source on debian (same version)
3°I recompile the source with a pbuilder chroot
4°I try the same command with the newly compiled version... it fails

gni?

[Laurent Bigonville (bigon)]

I create a chroot with debootstrap (debian etch) and recompile the ubuntu
package in it.... Everything works...

[Laurent Bigonville (bigon)]

The problem still present in flight cd2
The problem is maybe in kernel hearders

[Paul Sladen (sladen)]

Hello Laurent, this this still happening with latest Dapper on ppc?

[Laurent Bigonville (bigon)]

yes, the problem still happening with my up-to-date dapper

[Laurent Bigonville (bigon)]

It's an endianess problem...

The struct 'iphdr' is defined in /usr/include/linux/ip.h. In this struct there is a check for the endianess of the machine. The problem is with de definition of __LITTLE_ENDIAN and __BIG_ENDIAN, both are defined!!!!!!

[Laurent Bigonville (bigon)]

Found the problem..

__LITTLE_ENDIAN and __BIG_ENDIAN are always defined...

The test must use _LITTLE_ENDIAN and _BIG_ENDIAN only one underscore.

[Laurent Bigonville (bigon)]

The patch only remove an underscore.. Upstream makes this differently but this doesn't seem to work with this version of the headers

[Laurent Bigonville (bigon)]

Close this bug for iproute but it needs to be recompiled

[Laurent Bigonville (bigon)]

The problem is not limited to the linux/ip.h header... A lot of other header files are concerned

[Laurent Bigonville (bigon)]

This new patch changes the other files that are concerned with this problem.

[Laurent Bigonville (bigon)]

I just have a look upstream and at debian's package and I don't understand why you've changed all the __BIG_ENDIAN_BITFIELD and __LITTLE_ENDIAN_BITFIELD

[Martin Pitt (pitti)]

Reopening iproute task, it needs to be rebuilt against a fixed l-k-h

[Matt Zimmerman (mdz)]

Has l-k-h been fixed? Is anyone working on it?

[Jeff Bailey (jbailey)]

Patch1 tested and uploaded to lkh. Given that these headers have been in use for over a year, I'm not comfortable blindly applying the changes to the rest.

I'll leave the bug open, however, to make sure that I write tests for those other things.

[Jeff Bailey (jbailey)]

Important fix for 6.06-LTS uploaded, retargetting for after that with normal severity for remainder of fixes.

[Laurent Bigonville (bigon)]

lkh has been updated in edgy (version 2.6.17), almost everything seems to be ok now.

The patch corrects the last thing that could be a problem.

[Laurent Bigonville (bigon)]

oups

[Martin Pitt (pitti)]

linux-kernel-headers are now built from the main linux source, reassigning. The patch still applies, but I leave the judging to the kernel team.