gdesklets status icon should support a11y
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gDesklets |
Fix Released
|
Medium
|
gDesklets Core Team |
Bug Description
Steps to reproduce:
1. Run gdesklets to make this app running and the icon is showing the notification area.
2. Press <Alt><Ctrl><Tab> to move focus onto bottom panel.
3. Press <Arrow> to move focus onto gdesklets icon in notification area.
4. Press <Shift><F10> to popup right click menu.
Expected result:
The right click menu can popup, the accessx keys works for notification area.
Actual result:
User can move focus into notification area, but <shift><F10> doesn't work.
This is a very basic a11y functionality that all gnome based application should support, and we can support it with tiny modification of code.
See attached patch:
in main/Trayicon.py
the button event is filter by a if statement.
if (button == 3):
Actually, the if statement is redundancy, as the work has already done by gtkstatusicon. remove the if statement will not affect the behaviors of the statusicon.
However, the keyboard event is button == 0 and has been filtered by the if statement. After remove the if statement, we can fix the problem.
I also added position function into popup function to ensure the menu is pop up at the correct position when control with keyboard
self._
the select_first is used when navigate with keyboard, to disable the automatically highlight on the first menu item
Changed in gdesklets: | |
milestone: | none → release-of-0.36.3 |
Changed in gdesklets: | |
assignee: | Bjoern Koch (h.humpel) → gDesklets Core Team (gdesklets-core-team) |
importance: | Wishlist → Medium |
status: | Triaged → Confirmed |
Changed in gdesklets: | |
status: | Fix Committed → Fix Released |
Just pushed to bzr 0.3x (rev. 105).