Hard-coded line breaks (i18n, accessibility)

Bug #229314 reported by Martijn van Iersel
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Medium
Marc Tardif
hwtest (Ubuntu)
Fix Released
Medium
Marc Tardif

Bug Description

Binary package hint: hwtest-gtk

The hwtest-gtk app does not scale with the font, if you're using large fonts like I do (14pt for all system fonts) the text does not fit the dialog anymore. The dialog is not resizeable. I'll attach a screenshot.

This is on hardy.

Of course the workaround is to use a smaller system font, but the hardware testing dialog really should adjust itself to the font and not the other way around.

Revision history for this message
Martijn van Iersel (martijn-vaniersel) wrote :
Revision history for this message
Walter (walter74) wrote :

See attachment for what the hardware testing app looks like on my system. Looks like the same bug as this one.

Revision history for this message
Máté Őry (orymate) wrote :

This is also an i18n issue, developers should never hard-code line breaks. http://live.gnome.org/TranslationProject/DevGuidelines/Avoid%20hard-coded%20line%20breaks

That's why is Hungarian translation broken too. https://bugs.launchpad.net/ubuntu-hu-web/+bug/246271/comments/1

Revision history for this message
ronny (ronny-standtke) wrote :

I am using Ubuntu with the German locale and have the same problem. The text is not completely visible. Lines are cut off (see attached screenshot). Because the window is not resizeable, the only chance you have is to select all the text and paste it into a text editor.
Not something I would call state-of-the-art GUI design...

Revision history for this message
Siegfried Gevatter (rainct) wrote :

The problem that ronny described is even more visible using the Catalan locale. See the attached image.

Revision history for this message
Henrik Nilsen Omma (henrik) wrote :

Confirming issue. What the normal solution for this, wrappable text in a scrollable box?

Changed in hwtest:
importance: Undecided → Medium
status: New → Triaged
Changed in checkbox:
assignee: nobody → schwuk
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Abel Deuring (adeuring) wrote :

Wrappable text is of course good, but I think the main window could also be resizable. A larger window might make reading the texts easier or more convenient for large fonts.

Revision history for this message
David Murphy (schwuk) wrote :

I would prefer to stay with a fixed size window as it makes it easier to keep the testing experience consistent (although we will try a resizable window), however it should be larger by default.

Revision history for this message
Marc Tardif (cr3) wrote :

The problem with having a larger default size is that there will always be some language with more text and someone with larger fonts. So, at least enabling these corner cases by making the window resizable would be a good thing.

The problem with making the window resizable is that the application currently uses a fixed size image in the header. This is not something which I've seen in many other applications, probably for a good reason. However, removing the header completely makes the application feel empty.

Revision history for this message
Marc Tardif (cr3) wrote :

I have pushed a fix which at least makes the window resizable and preserve a decent looking header image. I would appreciate if someone else could confirm this is a reasonable fix and update the status accordingly.

Revision history for this message
David Murphy (schwuk) wrote :

It's an interesting fix (i.e. I would have tackled it a different way), but it works as far as resizing is concerned and that's good enough.

Revision history for this message
Marc Tardif (cr3) wrote :

I have also pushed another fix which also replaces the gtk labels with textviews instead. This makes each text area scrollable so that the application can still provide a usable interface when it is not resized.

Changed in checkbox:
assignee: schwuk → cr3
status: Confirmed → Fix Committed
Changed in hwtest:
assignee: nobody → cr3
status: Triaged → Fix Committed
Marc Tardif (cr3)
Changed in hwtest:
status: Fix Committed → Fix Released
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.