Please sync screenlets 0.1.1-2 (universe) from Debian unstable (main).

Bug #228789 reported by Emilio Pozuelo Monfort
12
Affects Status Importance Assigned to Milestone
screenlets (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 affects ubuntu/screenlets
 status confirmed
 importance wishlist
 subscribe ubuntu-archive

Please sync screenlets 0.1.1-2 (universe) from Debian unstable (main).

Explanation of the Ubuntu delta and why it can be dropped:

The base packaging is the same and our real diff, the patches, are all merged upstream.

Changelog since current intrepid version 0.0.12-0ubuntu5:

 screenlets (0.1.1-2) unstable; urgency=low
 .
   * debian/patches
    - 02_RSS_fix_import.patch : Don't crash the manager if python-feedparser
      is not installed.
    - 03-sticky-on-XFCE.patch : Keep sticky mode on restart for XFCE.
      Thanks Luca Niccoli for the patch (Closes: #480672)
    - 04-fix-clock-offset.patch : From upstream, update date of Clock
      Screenlet at midnight, even if there is an offset. (Closes:
      #458788)
    - 05-disable-Numeric-import.patch : From upstream, disable import
      Numeric, not necessary (Closes: #478462)
   * debian/control
    - Drop Depends on python-numeric.

screenlets (0.1.1-1) unstable; urgency=low

  * New upstream release (Closes: #477313)
  * debian/control
   - Add evolution as Suggests for EvolutionContacts Screenlet.
   - Add tomboy as Suggests for Tomboy Screenlet.
   - Add gnome-orca as Suggests for Speech Screenlets.
  * debian/copyright
   - Update with new Screenlets.
  * debian/rules
   - Remove binary-predeb rules for *.conf and RadioScreenlet.py, fixed
     upstream.
  * debian/patches/01-scipts-cleanup.patch
   - Update.

 -- Julien Lavergne <email address hidden> Thu, 08 May 2008 11:34:56 +0200

screenlets (0.1-1) unstable; urgency=low

  * New upstream release (Closes: #474510)
  * debian/patches
   - 02-Clean-Desktop.patch: removed, merged upstream.
   - 03-fix-menu-icon.patch: removed, merged upstream.
   - 05-clean-shebang.patch: removed, merged upstream.
   - 06-use-default-browser.patch: removed, merged upstream.
   - 01-scripts-cleanup.patch: Updated.
  * debian/control
   - Drop Build-Depends for the documentation.
   - Add python-gnome2-extras and iceweasel as Recommends for Web Screenlets.
  * debian/rules
   - Don't build documentation, included upstream.
   - Clean locale directory.
   - Fix 755 mode for png files.
  * debian/screenlets-doc.install
   - Update location of the documentation.
  * debian/copyright
   - Update to new Copyright for some screenlets.

 -- Julien Lavergne <email address hidden> Wed, 02 Apr 2008 19:42:37 +0200

screenlets (0.0.14-1) unstable; urgency=medium

  * New upstream release
  * Urgency to medium to fix RC bug (472024)
  * debian/rules
   - Remove rmdir for usr/lib, fixed with python-central 0.6 (Closes: #472024)
   - Move rm for feedparser.py to install/screenlets.
   - Add PYTHONPATH to build the documentation.
  * debian/patches
   - 01-scripts-cleanup.patch: delete bashism (Closes: #472897)
   - 05-clean-shebang.patch: remove useless shebang.
   - 06-use-default-browser.patch: Use default browser instead of Firefox.
   - 04-fix-crash-acpi.patch: removed, merged upstream.
   - 10-problem-on-create-tmpfile.patch: removed, merged upstream.
  * debian/control
   - Bump python-central Build-Depends to >= 0.6
   - Remove screenlets Build-Depends.
   - Add screenlets binary Depends to Build-Depends for the documentation.
   - Remove python-imaging as Recommends, SlideShow now doesn't use it.
  * debian/copyright
   - Update Copyright with new screenlets.
  * debian/watch
   - Switch to http, require by Launchpad.

 -- Julien Lavergne <email address hidden> Tue, 01 Apr 2008 20:38:48 +0200

screenlets (0.0.12-1) unstable; urgency=low

  * New upstream release.
  * debian/control
   - Add screenlets-doc binary.
   - Move python-central to Build-Depends-Indep.
   - Add python-epydoc, doc-base, python-docutils and screenlets
     Build-Depends-Indep to build API documentation.
   - Add python-imaging as Recommends for SlideShow Screenlets.
   - Add python-feedparser as Recommends for ClearRSS Screenlets.
   - Add python-gmenu as Recommends for MainMenu Screenlet.
   - Add python-numeric as Recommends for CleanWeather Screenlet.
   - Add python-chardet as Recommends for ClearRSS Screenlet.
   - Wrap Build Depends and Depends.
   - Add Suggest metacity (>= 2.21.4) which support composite.
   - Add Suggest python-dcop for the NowPlaying Screenlets.
   - Mention in the description that Screenlets work also on non-composited
     desktop.
  * debian/copyright
   - Update upstream authors.
   - Update Copyright and Licences.
  * debian/screenlets-doc.doc-base.screenlets
   - Add doc-base install file.
  * debian/rules
   - Build API docs.
   - Add a binary-predeb rule to delete empty /usr/lib folder and bad
     theme folder.
   - Remove feedparser.py in ClearRSS Screenlet, already in python-feedparser.
   - Remove other rm and rmdir commands, handle by *.install files.
   - Fix 755 mode for conf files.
   - Add screenletsd.1 in man pages.
  * debian/screenlets.install
   - Rename install to screenlets.install to add screenlets-doc package.
   - Install D-Bus service properly.
  * debian/screenlets-doc.install
   - Install docs files.
  * debian/screenlets.link
   - Rename links to screenlets.links.
  * debian/patches
   - Drop 09-delete-example-files.patch, handle by *.install files.
   - Drop 01-Install-to-usr-directory.patch, merged upstream.
   - Drop 04-Fix-python-heritage-empaty.patch, merged upstream.
   - Drop 05-Test-in-home-dir.patch, merged upstream.
   - Drop 06-Fix-error-type-pager-windowslist.patch, merged upstream.
   - Drop 07-Add-python-to-autostart-files.patch, merged upstream.
   - Drop 03-Clean-hashbang-shebang.patch: merged upstream.
   - 01-scripts-cleanup.patch: Replace bash by sh, add exec and python in
     some commands.
   - 02-Clean-Desktop.patch: Updated.
   - 03-fix-menu-icon.patch: Fix "non icon" bug in contextual menu.
  * debian/watch
   - Update to the new location of upstream tarball.
  * Debian/README
   - Update with the non-composite support.

 -- Julien Lavergne <email address hidden> Wed, 12 Mar 2008 22:00:30 +0100

screenlets (0.0.10-3) unstable; urgency=low

  [Marco Rodrigues]
  * Update Standards-Version to 3.7.3.

  [Julien Lavergne]
  * debian/patches:
   - 10-Import-screenlets-before-gtk.patch : Fix crash on startup with import
  gtk module after screenlets module (Closes: #455219)
  * debian/rules:
   - Delete empty /usr/lib directory

 -- Julien Lavergne <email address hidden> Mon, 17 Dec 2007 00:14:20 +0100

screenlets (0.0.10-2) unstable; urgency=low

  * debian/control : change priority to optional
  * debian/install
   - add dbus service for screenlets-daemon (Thanks Niv Sardi)
   - install svg image in /usr/share/icons/hicolor/scalable/apps/
  * debian/screenlets.links : add link for the new icon path
  * debian/rules : add upstream changelog
  * debian/patches
   - 08-add_timezone_support.patch : Add timezone support for ClockScreenlets (Thanks Niv Sardi)
   - 09-delete-example-files.patch : Delete examples until copyright fix
  * debian/screenlets-manager.1 & debian/screenlets-packager.1 : Clean man pages

 -- Julien Lavergne <email address hidden> Mon, 26 Nov 2007 23:50:01 +0100

screenlets (0.0.10-1) unstable; urgency=low

  [ Julien Lavergne ]
  * Initial release (Closes: #446783)
  * debian/patches/01-Install-to-usr-directory.patch : Install in /usr instead of /usr/local
  * debian/patches/02-Clean-Desktop.patch : Delete "Encoding", Exec screenlets-manager bin,
  add Type=Application to screenlets.daemon, move screenlets-manager to Utility.
  * debian/patches/04-Fix-python-heritage-empaty.patch : Delete the () in python class.
  * debian/patches/05-Test-in-home-dir.patch : test if $HOME/.config/Screenlets exit
  or create it, and create autostart file.
  * debian/patches/06-Fix-error-type-pager-windowslist.patch : Fix TypeError in
  active_window_changed() when Pager and Windowlist screenlets are running, and fix crash with
  __setattr__
  * debian/patches/07-Add-python-to-autostart-files.patch : add "python" to autostart
  files to make sure they start at login.

  [ Kumar Appaiah ]
  * debian/patches/03-Clean-hashbang-shebang.patch : Remove shebang and use #!/bin/sh.

 -- Julien Lavergne <email address hidden> Fri, 19 Oct 2007 16:52:50 +0200

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIJKWihTV17EoIsv4RAoSPAKDMzyNdhKPO0GTajbksNELniBGsLACfTJtt
UfmRGmNpzNAO1ha6EnRRtxg=
=GzBO
-----END PGP SIGNATURE-----

Revision history for this message
Helder Fraga (whise) wrote :

there is a bug on the debian downstream package that makes the manager unusable for those who dont have python feedparser package , this is a wrong behavior

this was added to the downstream package in the clearrss screenlet

try:
 import feedparser
except ImportError:
 dialog = gtk.MessageDialog(buttons=gtk.BUTTONS_CLOSE)
 dialog.set_markup("You don't have Feedparser installed! \nInstall python-feedparser or copy feedparser.py from rss/ folder to your screenlets folder.")
 dialog.run()
 dialog.destroy()
 print("You don't have Feedparser installed! \nInstall python-feedparser or copy feedparser.py from rss/ folder to your screenlets folder.")
 sys.exit()

this will make the manager to exit also , to avoid this please use the utils.is_manager_running_me() function to check if it is the manager or the actuall screenlet that is running

try:
 import feedparser
except ImportError:
        if utils.is_manager_running_me():
         print("You don't have Feedparser installed! \nInstall python-feedparser or copy feedparser.py from rss/ folder to your screenlets folder.")
        else:
            dialog = gtk.MessageDialog(buttons=gtk.BUTTONS_CLOSE)
         dialog.set_markup("You don't have Feedparser installed! \nInstall python-feedparser or copy feedparser.py from rss/ folder to your screenlets folder.")
           dialog.run()
         dialog.destroy()
         sys.exit()

Revision history for this message
Helder Fraga (whise) wrote :

so this obviously should not be ported to ubuntu yet and should be fixed in debian , i dont know how to report a bug in debian so i hope this reaches the package maintainers

i also hope no other screenlet was changed like this one .

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 228789] Re: Please sync screenlets 0.1.1-1 (universe) from Debian unstable (main).

No. It wasn't. The only patch is a patch to remove bashisms from
screenletsd.

Information about the Debian package (including the maintainer address) can be
found at:

http://packages.qa.debian.org/s/screenlets.html

This should be fine for a sync.

Revision history for this message
Helder Fraga (whise) wrote : Re: Please sync screenlets 0.1.1-1 (universe) from Debian unstable (main).

i downloaded the deb from the unstable debian

this is there:

try:
 import feedparser
except ImportError:
 dialog = gtk.MessageDialog(buttons=gtk.BUTTONS_CLOSE)
 dialog.set_markup("You don't have Feedparser installed! \nInstall python-feedparser or copy feedparser.py from rss/ folder to your screenlets folder.")
 dialog.run()
 dialog.destroy()
 print("You don't have Feedparser installed! \nInstall python-feedparser or copy feedparser.py from rss/ folder to your screenlets folder.")
 sys.exit()

i should know because im the upstream author , this is not the the logged patches ,i didnt code it , plus it creates a nasty bug

http://packages.debian.org/sid/all/screenlets/download

this is where i got the deb from

Revision history for this message
Helder Fraga (whise) wrote :

dam... thats not the problem sorry the problem is that feedparser.py was removed , so if the user doesnt have the python feedparser package it generates a nasty bug rendering screenlet manager unusable. so i sudgest if you remove the feedparser.py you should make python feedparser package required

Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

Whise,

I could switch python-feedparser from Recommends (which are installed by default, but can be removed) to Depends, which is the right place if not having it makes things crash. But would it be possible for you to make things stable even if it (and other external modules) are not in the system, for example showing a pop up? So we can keep them in Recommends, yet if someone doesn't want some modules he can't uninstall them.

From the changelog:

   - Add python-imaging as Recommends for SlideShow Screenlets.
   - Add python-feedparser as Recommends for ClearRSS Screenlets.
   - Add python-gmenu as Recommends for MainMenu Screenlet.
   - Add python-numeric as Recommends for CleanWeather Screenlet.
   - Add python-chardet as Recommends for ClearRSS Screenlet.

Changed in screenlets:
status: Confirmed → Incomplete
Revision history for this message
Julien Lavergne (gilir) wrote :

I don't want to put python-feedparser as Depends because it only needed for running ClearRSS. IMO, the bug is in ClearRSS Screenlets which don't need to crash the manager if feedparser is not installed.
I made a patch to fix this, I'll put it in the Debian package in the next revision.

@Whise, please take a look at the patch and see if you can include it in the bzr repo.

Revision history for this message
Helder Fraga (whise) wrote :

yes that should do it , thank you for your patience .

Also another thing less importante , python imaging is no longer required by the slideshow screenlet

Revision history for this message
Julien Lavergne (gilir) wrote :

screenlets 0.1.1-2 is now in Debian with the fix.

Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

Thanks, ready to sync

description: updated
Changed in screenlets:
status: Incomplete → Confirmed
Revision history for this message
Julien Lavergne (gilir) wrote :

screenlets 0.1.2 is now in Sid.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Getting binaries for intrepid...
[Updating] screenlets (0.0.12-0ubuntu5 [Ubuntu] < 0.1.2-1 [Debian])
 * Trying to add screenlets...
  - <screenlets_0.1.2-1.dsc: downloading from http://ftp.debian.org/debian/>
  - <screenlets_0.1.2.orig.tar.gz: downloading from http://ftp.debian.org/debian/>
  - <screenlets_0.1.2-1.diff.gz: downloading from http://ftp.debian.org/debian/>
I: screenlets [universe] -> screenlets_0.0.12-0ubuntu5 [universe].
I: screenlets [universe] -> screenlets-doc_0.0.12-0ubuntu5 [universe].

Changed in screenlets:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.