Lyrics Downloader not fetching lyrics

Bug #228033 reported by Matt Layman
2
Affects Status Importance Assigned to Milestone
Entertainer Media Center
Fix Released
Critical
Charclo

Bug Description

In the upgrade from Gutsy to Hardy, the lyrics downloader no longer fetches tracks for things that I know for certain was able to get before the upgrade.

Possibly related is the following backtrace (although this looks to be more associated with a clutter issue, but it comes up with the audio_play_screen.py):

Traceback (most recent call last):
  File "/home/matt/branches/cover-fix/src/frontend/gui/screens/audio_play_screen.py", line 204, in _update_progress_bar
    current_pos.set_text(self.player.get_media_position_string())
  File "/home/matt/branches/cover-fix/src/frontend/media_player.py", line 296, in get_media_position_string
    ns = self.playbin.query_position(gst.FORMAT_TIME, None)[0]
gst.QueryError: query failed
Traceback (most recent call last):
  File "/home/matt/branches/cover-fix/src/frontend/gui/widgets/loading_animation.py", line 184, in _rotate_throbber
    def _rotate_throbber(self):

Matt Layman (mblayman)
Changed in entertainer:
assignee: nobody → laymansterms
Revision history for this message
Charclo (charclo-michael) wrote :

This doesn't seem to be a bug from Hardy, I'm getting it too in Gutsy.
I just tried to search for a lyric on Leoslyrics.com and I get an error. And I also found a thread saying the database is down for more than a week now => http://www.leoslyrics.com/posts/list/18331.page

Revision history for this message
Joshua Scotton (joshuascotton) wrote :

Longterm I think we should aim for more than one source of lyrics
Shortterm we need to be able to handle the lyrics website going offline or Entertainer being used offline

Changed in entertainer:
importance: Undecided → Medium
Revision history for this message
Matt Layman (mblayman) wrote :

Charclo is seeing this problem too. Thanks for pointing out that it's not just Hardy. I guess this emphasizes the need for a lyrics plugin that uses multiple sources.

Changed in entertainer:
status: New → Confirmed
Paul Hummer (rockstar)
Changed in entertainer:
assignee: laymansterms → charclo-michael
importance: Medium → Critical
status: Confirmed → Triaged
Revision history for this message
Charclo (charclo-michael) wrote :

I think it would be best to use an other source for fetching lyrics as leoslyrics.com seems to be down a lot.
I found http://lyricsfly.com/api/ as a replacement.

Paul Hummer (rockstar)
Changed in entertainer:
milestone: none → 0.1-release
Revision history for this message
Matt Layman (mblayman) wrote :

Charclo, I'm going to remove the blueprint link to the bug. There is no way we're going to get a plugin architecture into Entertainer for .1. And the blueprint that is attached is dependent on that future architecture. I agree that we should implement something in .1 to replace the currently broken code, but it won't be a plugin version. I suggest we look at gutting out the actual fetching from leolyrics and replace it with lyricsfly for the time being in order to get lyrics working for .1. That way we can hopefully use most of the existing downloader, and only the fetching part will be different.

Changed in entertainer:
status: Triaged → In Progress
Paul Hummer (rockstar)
Changed in entertainer:
status: In Progress → Fix Committed
Revision history for this message
Matt Layman (mblayman) wrote :
Changed in entertainer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.