Coding style

Bug #226661 reported by Adam Rooke
2
Affects Status Importance Assigned to Milestone
PyRoom
Fix Released
Medium
Unassigned

Bug Description

First off, sorry for not contributing anything for the last few months but have been pretty busy. On study leave now though, so that leaves me lots of time :-) Nice to see that pyroom has still be progressing.

I think it would be a could idea if we modified the code so that it follows some of the standards suggested here: http://www.python.org/dev/peps/pep-0008/ so that we get a consistent style throughout that is consistent with other applications. This includes consistently using an_variable or AnVariable - we mix both throughout - I'm particularly guilty!

Any thoughts?

Revision history for this message
Bruno Bord (brunobord) wrote :

Why not starting a PEP-008 branch out of trunk, and merge it when the PEP it's fine?

This script might help checking source code:

http://trac.browsershots.org/browser/trunk/devtools/pep8/pep8.py?format=txt

Pylint helps a lot, too:

$ sudo apt-get install pylint

Revision history for this message
Nathan Haines (nhaines) wrote : Re: [Bug 226661] [NEW] Coding style

I have tried to make the code that I have dealt with conformant. This includes formatting all of the default themes. I definitely think all of our code shoulde be internally consistent and as close to PEP-0008 as possible.
Sent via BlackBerry from T-Mobile

Changed in pyroom:
assignee: nobody → caio-alonso
importance: Undecided → Medium
status: New → Confirmed
Changed in pyroom:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.