software-properties-gtk crashed with NameError in add_key_clicked()

[Arik]

put URL instead of local path in path selection box. I expected it to download the file (wishful thinking) or an error. Crashed the file selection box instead.

hardy's latest synaptic

ProblemType: Crash
Architecture: i386
Date: Sat May 3 02:41:54 2008
DistroRelease: Ubuntu 8.04
ExecutablePath: /usr/bin/software-properties-gtk
InterpreterPath: /usr/bin/python2.5
Package: software-properties-gtk 0.63ubuntu1
PackageArchitecture: all
ProcCmdline: /usr/bin/python /usr/bin/software-properties-gtk -n -t 58720385
ProcEnviron:
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin
 LANG=en_US.UTF-8
 SHELL=/bin/bash
PythonArgs: ['/usr/bin/software-properties-gtk', '-n', '-t', '58720385']
SourcePackage: software-properties
Title: software-properties-gtk crashed with NameError in add_key_clicked()
Traceback:
 Traceback (most recent call last):
   File "/usr/lib/python2.5/site-packages/softwareproperties/gtk/SoftwarePropertiesGtk.py", line 755, in add_key_clicked
     error(self.window_main,
 NameError: global name 'error' is not defined
Uname: Linux 2.6.24-16-generic i686
UserGroups:

[James Westby (james-w)]

Hi,

Thanks for taking the time to report this bug.

There are two places in this file, and possibly others in other files
that call "error", I suspect it may be an old function, and not all
code was migrated. I'm not sure what it should be replaced with,
otherwise I would submit a patch.

Thanks,

James

[Sebastian Heinlein (glatzor)]

Here is the fix. It also contains a fix in the lower level key handling. (errors haven't been reported correctly)

[Uphaar Agrawalla (uphaar)]

The crash is present in Intrepid - same way to reproduce.

[Martin Olsson (mnemo)]

Present in jaunty as of march 10th, I entered "*" in the "add key" browse dialog...

[Jonas Eberle (jonas-eberle)]

Does not crash in Jaunty-updates as of Mai 05, but ouputs

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/softwareproperties/gtk/SoftwarePropertiesGtk.py", line 761, in add_key_clicked
    error(self.window_main,
NameError: global name 'error' is not defined

No key downloaded. Its a minor one I would say, as it does not crash.

[Robert Roth (evfool)]

Thank you for reporting this bug to Ubuntu. Jaunty reached EOL on October 23, 2010
Please see this document for currently supported Ubuntu releases:
https://wiki.ubuntu.com/Releases

I've tried recreating this bug with Oneiric and was unable to, given the information you've provided. Please either a) upgrade and test or b) increase the verbosity of the steps to recreate it so we can try again.

Please feel free to report any other bugs you may find.

[Launchpad Janitor (janitor)]

[Expired for software-properties (Ubuntu) because there has been no activity for 60 days.]