Ubuntu
libpng package

libpng: FTBFS when awk is provided by gawk

Bug #22353 reported by Debian Bug Importer
4
Affects Status Importance Assigned to Milestone
libpng (Debian)
Fix Released
Unknown
libpng (Ubuntu)
Invalid
High
Adam Conrad

Bug Description

Automatically imported from Debian bug report #329812 http://bugs.debian.org/329812

See original description
Revision history for this message
Debian Bug Importer (debzilla) wrote :

Automatically imported from Debian bug report #329812 http://bugs.debian.org/329812

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (3.4 KiB)

Message-Id: <email address hidden>
Date: Fri, 23 Sep 2005 16:16:15 +0200
From: Aurelien Jarno <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: libpng: FTBFS when awk is provided by gawk

--===============0087526773==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: libpng
Version: 1.2.8rel-3
Severity: serious
Tags: patch

Hi,

libpng fails to build when awk is provided by gawk, but builds well when
awk is provided by mawk. See below:

...

awk -F '[\t [\]();]' -v PNGMAJ=0 'BEGIN{printf("PNG12_%s {global:\n",PNGMAJ)}\
{ for (i=1;i+2<=NF;++i)\
 if ($(i)=="PNG_FUNCTION_EXPORT" && $(i+2)=="END")\
  print $(i+1) ";";\
for (i=1;i+1<=NF;++i)\
 if ($(i)=="PNG_DATA_EXPORT")\
  print $(i+1) ";";}\
END{print "local: *; };"}' >libpng.syms.new
awk: warning: escape sequence `\]' treated as plain `]'
rm -f libpng.syms
mv libpng.syms.new libpng.syms
gcc -shared -lz -lm -Wl,-soname,libpng12.so.0 \
-Wl,-version-script,libpng.syms \
-o libpng12.so.0.1.2.8 \
png.pic.o pngset.pic.o pngget.pic.o pngrutil.pic.o pngtrans.pic.o pngwutil.pic.o pngread.pic.o pngrio.pic.o pngwio.pic.o pngwrite.pic.o pngrtran.pic.o pngwtran.pic.o pngmem.pic.o pngerror.pic.o pngpread.pic.o
/usr/bin/ld:libpng.syms:2: syntax error in VERSION script
collect2: ld returned 1 exit status
make[1]: *** [libpng12.so.0.1.2.8] Error 1
make[1]: Leaving directory `/build/buildd/libpng-1.2.8rel'
make: *** [debian/stamp-makefile-build] Error 2

...

awk is always installed on a Debian system (via base-files), but you
can't be sure which one of mawk and gawk will be installed. As libpng
use mawk functionalities, you need to build-depends on it, and call mawk
instead of awk.

Please find attached a patch to do that.

I have set the severity of the bug to serious, but as mawk seems to be
the package installed by default on a system, you may want to decrease
the severity of the bug.

Bye,
Aurelien

-- System Information:
Debian Release: testing/unstable
Architecture: kfreebsd-i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: GNU/kFreeBSD 5.4-1-686
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)

--===============0087526773==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="libpng_awk.patch"

diff -u libpng-1.2.8rel/debian/control libpng-1.2.8rel/debian/control
--- libpng-1.2.8rel/debian/control
+++ libpng-1.2.8rel/debian/control
@@ -2,7 +2,7 @@
 Section: libs
 Priority: optional
 Maintainer: Josselin Mouette <email address hidden>
-Build-Depends: debhelper (>= 4.2), zlib1g-dev, cdbs
+Build-Depends: debhelper (>= 4.2), zlib1g-dev, cdbs, mawk
 Standards-Version: 3.6.2

 Package: libpng12-0
diff -u libpng-1.2.8rel/debian/patches/makefile.patch libpng-1.2.8rel/debian/patches/makefile.patch
--- libpng-1.2.8rel/debian/patches/makefile.patch
+++ libpng-1.2.8rel/debian/patches/makefile.patch
@@ -35,7 +35,7 @@
  libpng.syms: png.h pngconf.h
   $(CC) $(CFLAGS) -E -DPNG_BUILDSYMS png.h |\
 - awk -F '[\t [\]();]' 'BEGIN{print "{global:"}\
-+ awk -F '[\t [\]();]' -v PNGMAJ=$(PNGMAJ...

Read more...

Revision history for this message
In , Josselin Mouette (joss) wrote : Bug#329812: fixed in libpng 1.2.8rel-4
Download full text (3.2 KiB)

Source: libpng
Source-Version: 1.2.8rel-4

We believe that the bug you reported is fixed in the latest version of
libpng, which is due to be installed in the Debian FTP archive:

libpng12-0-udeb_1.2.8rel-4_i386.udeb
  to pool/main/libp/libpng/libpng12-0-udeb_1.2.8rel-4_i386.udeb
libpng12-0_1.2.8rel-4_i386.deb
  to pool/main/libp/libpng/libpng12-0_1.2.8rel-4_i386.deb
libpng12-dev_1.2.8rel-4_i386.deb
  to pool/main/libp/libpng/libpng12-dev_1.2.8rel-4_i386.deb
libpng3_1.2.8rel-4_all.deb
  to pool/main/libp/libpng/libpng3_1.2.8rel-4_all.deb
libpng_1.2.8rel-4.diff.gz
  to pool/main/libp/libpng/libpng_1.2.8rel-4.diff.gz
libpng_1.2.8rel-4.dsc
  to pool/main/libp/libpng/libpng_1.2.8rel-4.dsc

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Josselin Mouette <email address hidden> (supplier of updated libpng package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 25 Sep 2005 15:25:34 +0200
Source: libpng
Binary: libpng12-dev libpng12-0 libpng12-0-udeb libpng3
Architecture: source i386 all
Version: 1.2.8rel-4
Distribution: unstable
Urgency: low
Maintainer: Josselin Mouette <email address hidden>
Changed-By: Josselin Mouette <email address hidden>
Description:
 libpng12-0 - PNG library - runtime
 libpng12-0-udeb - PNG library - minimal runtime library (udeb)
 libpng12-dev - PNG library - development
 libpng3 - PNG library - runtime
Closes: 329812 329886
Changes:
 libpng (1.2.8rel-4) unstable; urgency=low
 .
   * makefile.patch:
     + Use PNG_PRIVATE to get the list of private symbols as well. It
       sucks, but they've been there for too long (closes: #329886).
     + Use mawk instead of awk (closes: #329812).
   * control: build-depend on mawk.
   * rules:
     + Use -O2, not -O3.
     + Actually run the tests.
     + Make use of x86_patches/ on x86 architectures.
   * x86_patches/mmxbuild.patch: build MMX routines in pnggccrd.c.
   * x86_patches/pnggccrd-PIC.patch: patch from Christian Aichinger
     to make the assembly routines PIC-compatible.
   * libpng12-0.shlibs: bump the shlibs version.
Files:
 bfc0f4fe4eb13669d074e247b76d8136 634 libs optional libpng_1.2.8rel-4.dsc
 fc0ea54812bc5be68c14b1513202a90d 15597 libs optional libpng_1.2.8rel-4.diff.gz
 9eda66d0defa473a11eff4d2cbe3986e 836 oldlibs optional libpng3_1.2.8rel-4_all.deb
 9ef9c251783ca542db1d3a2b471590ea 112696 libs optional libpng12-0_1.2.8rel-4_i386.deb
 dcc106490f19206b43810fc21017a4fd 242750 libdevel optional libpng12-dev_1.2.8rel-4_i386.deb
 61ec625a493b5866e2012ef4fbf73483 68888 debian-installer optional libpng12-0-udeb_1.2.8rel-4_i386.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDNrQDrSla4ddfhTMRAheRAKDiNOw85Eiv+7z/sqZ7/3Jp1A0FHwCgsniO
jZBk25Ht877nvu2mKEnPREI=
=...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (3.4 KiB)

Message-Id: <email address hidden>
Date: Sun, 25 Sep 2005 07:32:08 -0700
From: Josselin Mouette <email address hidden>
To: <email address hidden>
Subject: Bug#329812: fixed in libpng 1.2.8rel-4

Source: libpng
Source-Version: 1.2.8rel-4

We believe that the bug you reported is fixed in the latest version of
libpng, which is due to be installed in the Debian FTP archive:

libpng12-0-udeb_1.2.8rel-4_i386.udeb
  to pool/main/libp/libpng/libpng12-0-udeb_1.2.8rel-4_i386.udeb
libpng12-0_1.2.8rel-4_i386.deb
  to pool/main/libp/libpng/libpng12-0_1.2.8rel-4_i386.deb
libpng12-dev_1.2.8rel-4_i386.deb
  to pool/main/libp/libpng/libpng12-dev_1.2.8rel-4_i386.deb
libpng3_1.2.8rel-4_all.deb
  to pool/main/libp/libpng/libpng3_1.2.8rel-4_all.deb
libpng_1.2.8rel-4.diff.gz
  to pool/main/libp/libpng/libpng_1.2.8rel-4.diff.gz
libpng_1.2.8rel-4.dsc
  to pool/main/libp/libpng/libpng_1.2.8rel-4.dsc

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Josselin Mouette <email address hidden> (supplier of updated libpng package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 25 Sep 2005 15:25:34 +0200
Source: libpng
Binary: libpng12-dev libpng12-0 libpng12-0-udeb libpng3
Architecture: source i386 all
Version: 1.2.8rel-4
Distribution: unstable
Urgency: low
Maintainer: Josselin Mouette <email address hidden>
Changed-By: Josselin Mouette <email address hidden>
Description:
 libpng12-0 - PNG library - runtime
 libpng12-0-udeb - PNG library - minimal runtime library (udeb)
 libpng12-dev - PNG library - development
 libpng3 - PNG library - runtime
Closes: 329812 329886
Changes:
 libpng (1.2.8rel-4) unstable; urgency=low
 .
   * makefile.patch:
     + Use PNG_PRIVATE to get the list of private symbols as well. It
       sucks, but they've been there for too long (closes: #329886).
     + Use mawk instead of awk (closes: #329812).
   * control: build-depend on mawk.
   * rules:
     + Use -O2, not -O3.
     + Actually run the tests.
     + Make use of x86_patches/ on x86 architectures.
   * x86_patches/mmxbuild.patch: build MMX routines in pnggccrd.c.
   * x86_patches/pnggccrd-PIC.patch: patch from Christian Aichinger
     to make the assembly routines PIC-compatible.
   * libpng12-0.shlibs: bump the shlibs version.
Files:
 bfc0f4fe4eb13669d074e247b76d8136 634 libs optional libpng_1.2.8rel-4.dsc
 fc0ea54812bc5be68c14b1513202a90d 15597 libs optional libpng_1.2.8rel-4.diff.gz
 9eda66d0defa473a11eff4d2cbe3986e 836 oldlibs optional libpng3_1.2.8rel-4_all.deb
 9ef9c251783ca542db1d3a2b471590ea 112696 libs optional libpng12-0_1.2.8rel-4_i386.deb
 dcc106490f19206b43810fc21017a4fd 242750 libdevel optional libpng12-dev_1.2.8rel-4_i386.deb
 61ec625a493b5866e2012ef4fbf73483 68888 debian-installer optional lib...

Read more...

Revision history for this message
Fabio Massimo Di Nitto (fabbione) wrote :

it doesn't affect us.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.