Eraser tool breaks build

[Rygle]

Looks nice in the blog. Sorry but it breaks the Win32 build, which possibly means other platforms also, but I can test that.

I think you need to add something more into the patch you've merged into trunk.

Here's the error I get from the command prompt during build. Latest trunk. Win XP SP2. Latest devlibs and mingw from Ishmal's site - http://inkscape.modevia.com
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    cc : compile of build/obj/tools-switch.o required by source: src/tools-switc
h.cpp
============ cmd ============
mingw32-g++ -c -Wall -Wformat-security -W -Wpointer-arith -Wcast-align -Wsign-co
mpare -Woverloaded-virtual -Wswitch -O2 -mms-bitfields -DVERSION=\"0.46+devel\"
-DHAVE_CONFIG_H -DXP_WIN -D_INTL_REDIRECT_INLINE -DHAVE_SSL -DRELAYTOOL_SSL="sta
tic const int libssl_is_present=1; static int __attribute__((unused)) libssl_sym
bol_is_present(char *s){ return 1; }" -I. -Ic:/devlibs/include -Ic:/devlibs/incl
ude/glibmm-2.4 -Ic:/devlibs/lib/glibmm-2.4/include -Ic:/devlibs/include/gtkmm-2.
4 -Ic:/devlibs/lib/gtkmm-2.4/include -Ic:/devlibs/include/gdkmm-2.4 -Ic:/devlibs
/lib/gdkmm-2.4/include -Ic:/devlibs/include/pangomm-1.4 -Ic:/devlibs/include/atk
mm-1.6 -Ic:/devlibs/include/cairomm-1.0 -Ic:/devlibs/include/sigc++-2.0 -Ic:/dev
libs/lib/sigc++-2.0/include -Ic:/devlibs/include/gtk-2.0 -Ic:/devlibs/lib/gtk-2.
0/include -Ic:/devlibs/include/atk-1.0 -Ic:/devlibs/include/pango-1.0 -Ic:/devli
bs/include/glib-2.0 -Ic:/devlibs/lib/glib-2.0/include -Ic:/devlibs/include/libxm
l2 -Ic:/devlibs/include/freetype2 -Ic:/devlibs/include/cairo -Ic:/devlibs/includ
e/poppler -Ic:/devlibs/include/gc -Ic:/devlibs/include/libwpg-0.1 -Ic:/devlibs/i
nclude/libwpd-0.8 -Ic:/devlibs/python/include -Isrc/bind/javainc -Isrc/bind/java
inc/win32 -Isrc -Isrc/2geom -Isrc/application -Isrc/bind -Isrc/debug -Isrc/dia
logs -Isrc/display -Isrc/dom -Isrc/dom/io -Isrc/dom/odf -Isrc/dom/util -Isrc/ext
ension -Isrc/extension/implementation -Isrc/extension/internal -Isrc/extension/i
nternal/bitmap -Isrc/extension/internal/filter -Isrc/extension/internal/pdfinput
 -Isrc/extension/script -Isrc/graphlayout -Isrc/helper -Isrc/inkjar -Isrc/io -Is
rc/jabber_whiteboard -Isrc/jabber_whiteboard/dialog -Isrc/libavoid -Isrc/libcola
 -Isrc/libcroco -Isrc/libgdl -Isrc/libnr -Isrc/libnrtype -Isrc/libvpsc -Isrc/lib
vpsc/pairingheap -Isrc/livarot -Isrc/live_effects -Isrc/live_effects/parameter -
Isrc/pedro -Isrc/removeoverlap -Isrc/svg -Isrc/trace -Isrc/trace/potrace -Isrc/u
i -Isrc/ui/cache -Isrc/ui/dialog -Isrc/ui/view -Isrc/ui/widget -Isrc/util -Isrc/
widgets -Isrc/xml src/tools-switch.cpp -o build/obj/tools-switch.o
=============================
Make error line 201: problem compiling: src/tools-switch.cpp:43:28: error: erase
r-context.h: No such file or directory
src/tools-switch.cpp: In function 'void tools_switch(SPDesktop*, int)':
src/tools-switch.cpp:244: error: 'SP_TYPE_ERASER_CONTEXT' was not declared in th
is scope
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------

[ScislaC (scislac)]

Jon Cruz,
You forgot to commit eraser-context.h & eraser-context.cpp. :)

[Rygle (rygle)]

Dude!

[Rygle (rygle)]

Bulia said (on inkscape-dev)
=====

linux too

make: *** No rule to make target `eraser-context.o', needed by
`libinkpre.a'. Stop.

=====

Seems to be related to those same two files missing.

[Jon A. Cruz (jon-joncruz)]

Missing files added.

[Rygle (rygle)]

Builds OK on Windows. Generally seems to work OK, but no erasing at this stage even for a single ungrouped object (I think that's intended presently as this is in development).

Does do a hard crash when trying to open two files I've got, but don't know if this crash is related, or could be something else altogether. Will try to test more tomorrow. Most files OK.

[Rygle (rygle)]

Don't think the crashes were related to this patch. Seems to possibly be related to Win32 native dialogues.

[Rygle (rygle)]

I said 2 posts back;
>no erasing at this stage even for a single ungrouped object (I think that's intended presently as this is in development).

Realised that my eraser failure was because I was trying to erase strokes, not paths. Would be nice if this did work for strokes as well as paths.