Unrecoverable error during upgrade from 6.06 to 8.04

[Jendos]

Binary package hint: update-manager

TEST CASE:
1. install dapper
2. change /etc/apt/sources.list to contain
    deb ftp://ftp.chg.ru/pub/Linux/ubuntu/archive dapper main multiverse restricted universe
    deb-src http://archive.ubuntu.com/ubuntu dapper main
3. try the upgrade, verify that it breaks

4. run "do-release-upgrade --proposed --mode desktop"
5. verify that the upgrade continues (its enough if it gets to the point when it can be calcuated)

The update manager ask me to send an error report:
-------------------------------------------------------------------------------------------------------------
Traceback (most recent call last):

  File "/tmp/tmptX5Q6v/hardy", line 60, in ?
    app.run()

  File "/tmp/tmptX5Q6v/DistUpgradeController.py", line 1550, in run
    self.fullUpgrade()

  File "/tmp/tmptX5Q6v/DistUpgradeController.py", line 1513, in fullUpgrade
    if not self.askDistUpgrade():

  File "/tmp/tmptX5Q6v/DistUpgradeController.py", line 803, in askDistUpgrade
    if not self.cache.distUpgrade(self._view, self.serverMode, self.partialUpgrade):

  File "/tmp/tmptX5Q6v/DistUpgradeCache.py", line 128, in wrapper
    res = f(*args, **kwargs)

  File "/tmp/tmptX5Q6v/DistUpgradeCache.py", line 605, in distUpgrade
    if not self._installMetaPkgs(view):

  File "/tmp/tmptX5Q6v/DistUpgradeCache.py", line 778, in _installMetaPkgs
    self[key].markInstall()

  File "/build/buildd/release-upgrader-apt-0.7.9ubuntu2/python-apt-0.7.4ubuntu6/debian/python2.4-apt/usr/lib/python2.4/site-packages/apt/cache.py", line 91, in __getitem__

KeyError: 'ubuntu-desktop'
----------------------------------------------------------------------------
and attach following files: /var/log/dist-upgrade/main.log and /var/log/dist-upgrade/apt.log

[Michael Vogt (mvo)]

Thanks for your bugreport.

It looks like your mirror is not part of the known mirros file. I added it now and it will be part of the next upload. As a workaround, please switch to a different mirror.

[Martin Pitt (pitti)]

Accepted into hardy-proposed, please test.

[Michael Vogt (mvo)]

Here is a better fix (applied in intrepid) - if I see this particular problem more often I will ask for it for hardy-proposed:

=== modified file 'DistUpgrade/DistUpgradeController.py'
--- DistUpgrade/DistUpgradeController.py 2008-05-06 09:03:12 +0000
+++ DistUpgrade/DistUpgradeController.py 2008-05-06 13:44:02 +0000
@@ -486,6 +486,7 @@
                 # need to add one
                 validTo = True
                 if (entry.disabled or
+ entry.type == "deb-src" or
                     entry.uri.startswith("http://security.ubuntu.com") or
                     entry.uri.startswith("http://archive.canonical.com")):
                     validTo = False

=== modified file 'debian/changelog'
--- debian/changelog 2008-05-06 12:41:47 +0000
+++ debian/changelog 2008-05-06 13:44:57 +0000
@@ -2,6 +2,10 @@

   * DistUpgrade/DistUpgradeCache.py:
     - fix bug in withNetwork value propergation (LP: #227197)
+ * DistUpgrade/DistUpgradeController.py:
+ - fix bug with sources.list rewriting when mixed
+ deb http://unknown-miror\ndeb-src http://known-mirror
+ entries are used (#221730)

[Brian Murray (brian-murray)]

I have verified this bug by following the provided test case and after modifying my /etc/apt/sources.list file to use ftp://ftp.chg.ru/pub/Linux/ubuntu/archive I was unable to successfully upgrade to Hardy. After using 'do-release-upgrade --proposed --mode desktop' I was able to upgrade to Hardy.

[Martin Pitt (pitti)]

Although not all fixed bugs have been verified, four tests from Brian showed that update-manager is still able to upgrade from dapper and gutsy, and fixed some bugs. Due to the urgency of some bugs I have copied this to hardy-updates now.