System monitor applet: incorrect sort order of entries when size > 2048M

[Fedor Isakov]

The system monitor applet displays processes with resident/virtual memory size > 2048 at the bottom of the list. Apparently this is due to signed int used to represent memory size in bytes, which turns negative as soon as the size grows over 2^31.

Hardy/64, awn-core-applets-bzr 0.3.1.bzr439.1~hardy from http://ppa.launchpad.net/reacocard-awn/ubuntu/.

[moonbeam (rcryderman)]

I thought I had this patched a few months ago... I guess the silence I received when I asked for it to be tested was not an indication of it being fixed. I'll have a look.

[moonbeam (rcryderman)]

Committed rev 447. It'll probably show up in the PPA and reacocard's repo sometime soon.

If this doesn't fix it then I'll have a more detailed look at the code again... I had previously went in and, I believe, hunted down all the signed int s used and replaced with guint64. However I did make a couple structure members guint. I've switched them to guint64. I'm not sure that is the cause though as I wouldn't expect that to cause the behavior you're seeing... instead I would expect an issue at >4096. Anyway, please test.

[Fedor Isakov (fisakov)]

The bug that was fixed dealt with how size was displayed, and that was indeed fixed.

[moonbeam (rcryderman)]

Additional commit. rev 448. Fixed some comparison routines to account for the change to guint64.

[moonbeam (rcryderman)]

Fedor,

Thanks for the clarification - I'm glad the previous issue was resolved. I _suspect_ rev 448 will fix this issue until such time as process sizes begin to exceed 2^32.

[moonbeam (rcryderman)]

Fedor,

  Are you still being affected by this bug?

[Fedor Isakov (fisakov)]

Not anymore, as of awn-core-applets-bzr version 0.3.1.bzr473.1~hardy.

Thanks.