Doesn't append _ to nick if it is already in use

Bug #215858 reported by Chris Ortner
2
Affects Status Importance Assigned to Milestone
P1tr
Fix Committed
Low
Michael Otteneder

Bug Description

When connecting to a server P1tr usually tried a nickname. If it was already in use by someone else he appended an underscore to it, if necessary two and so on. This functions doesn't seem to work any longer. When connecting to a server where the nick specified in P1tr's config file is in use nothing happens. The bot appears frozen on the command line. There is no message of any failure.
So far I only tested revision 96 with no changes using Python 2.5.2 on Linux 2.6.

Changed in p1tr:
assignee: nobody → m-otteneder
importance: Undecided → Low
milestone: none → beta
status: New → Confirmed
Revision history for this message
Michael Otteneder (m-otteneder) wrote :

Well I get this exception when the nick is already in use:
ile "/System/Library/Frameworks/Python.framework/Versions/2.5/Extras/lib/python/twisted/internet/selectreactor.py", line 139, in _doReadOrWrite
    why = getattr(selectable, method)()
  File "/System/Library/Frameworks/Python.framework/Versions/2.5/Extras/lib/python/twisted/internet/tcp.py", line 531, in doConnect
    self.failIfNotConnected(error.getConnectError((connectResult, os.strerror(connectResult))))
  File "/System/Library/Frameworks/Python.framework/Versions/2.5/Extras/lib/python/twisted/internet/tcp.py", line 467, in failIfNotConnected
    self.connector.connectionFailed(failure.Failure(err))
  File "/System/Library/Frameworks/Python.framework/Versions/2.5/Extras/lib/python/twisted/internet/base.py", line 690, in connectionFailed
    self.factory.clientConnectionFailed(self, reason)
  File "/Users/mc/dev/p1tr/lib/core.py", line 128, in clientConnectionFailed
    log('f', 'Connection failed: ' + reason)
<type 'exceptions.TypeError'>: cannot concatenate 'str' and 'instance' objects

Changed in p1tr:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.