breaks readConfig() API

[jiri]

Binary package hint: jockey-kde

Hello,

I am using Kubuntu 8.04 beta. When i try to start jockey-kde it crashes with the following error messages:

$ jockey-kde
Traceback (most recent call last):
  File "/usr/bin/jockey-kde", line 367, in <module>
    sys.exit(u.run())
  File "/usr/lib/python2.5/site-packages/jockey/ui.py", line 266, in run
    self.ui_init()
  File "/usr/bin/jockey-kde", line 126, in ui_init
    self.update_tree_model()
  File "/usr/bin/jockey-kde", line 317, in update_tree_model
    is_enabled = handler.enabled()
  File "/usr/share/jockey/handlers/nvidia.py", line 50, in enabled
    devices = self.xorg_conf.getSections('device')
AttributeError: 'tuple' object has no attribute 'getSections'

The Version of jockey-kde is 0.3.3-0ubuntu7.

Best Regards

Jiri

[wretchedmage (alex813)]

I comfired this. I don't know how to install the nvidia driver without this.

[george moody (georgemoody)]

i found a fix for the gtk version that seems to reslove this issue

the api in guidance-backends, namely in /usr/share/python-support/guidance-backends/xorgconfig.py seems to have changed. This causes self.xorg_conf to be a tuple of XorgConfig and bool rather than a simple XorgConfig.

Changing line 60 in /usr/lib/python2.5/site-packages/jockey/xorg_driver.py from
                self.xorg_conf = xorgconfig.readConfig(OSLib.inst.xorg_conf_path)
to
                self.xorg_conf = xorgconfig.readConfig(OSLib.inst.xorg_conf_path)[0]

fixes the problem. I'm not sure what one could use the boolean value in the tuple for since it looks like an XorgConfig instance is created anyways or an Exception raised. And in anyy case xorg_driver.py simply fills in None if there was an exception. Anyway it might still be bad style to simply ignore that bool. Yet it seems to work. diff -Nurp is attatched.

[Rocklobster (jhecker)]

Nice work. As of 12-April-08 I was still having the problem of jockey-kde crashing and not being able to get the nvidia driver working. Placing a [0] at the end of lines 69 and 180 in the to date version of /usr/lib/python2.5/site-packages/jockey/xorg_driver.py got it working again. Now to reboot to see if the "nvidia" driver functions as hoped.

Not long until 24 April. They need to get this stuff sorted out ASAP or the Kubuntu n00bs will want their money back! Oh... wait...

[Rocklobster (jhecker)]

The above fix worked after a reboot. Nvidia driver now loads.