After setting cookie_secure to True, BrowserIdManger keeps accepting already set cookies through plain HTTP

Bug #211437 reported by Servilio Afre Puentes
2
Affects Status Importance Assigned to Milestone
Zope 2
Invalid
Low
Unassigned

Bug Description

It is contradictory/inconsistent to configure the BrowserIdManager to send cookies only over HTTPS and still accept some of them (the ones already set before the configuration change, so this set is built randomly/non-deterministically) over plain HTTP.

The consistent behavior for this property is to delete cookies sent over plain HTTP once the cookie_secure attribute has been set to True (thus forcing regenerating the browser ID), and conversely, when set to False resending the same cookie with the secure attribute off.

The attached patch implements the first case.

Revision history for this message
Servilio Afre Puentes (servilio) wrote :
Revision history for this message
Servilio Afre Puentes (servilio) wrote :

Also, no test is implemented yet.

Tres Seaver (tseaver)
Changed in zope2:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Colin Watson (cjwatson) wrote :

The zope2 project on Launchpad has been archived at the request of the Zope developers (see https://answers.launchpad.net/launchpad/+question/683589 and https://answers.launchpad.net/launchpad/+question/685285). If this bug is still relevant, please refile it at https://github.com/zopefoundation/zope2.

Changed in zope2:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.