Silva Link preview tab should display rendered http link

[Andy Altepeter]

Says Kit:
When a user goes to preview, they end up in the destination of the link. I've never liked this about the Link object, as there's no way to see what it's (versioned) content is, you have to make a new version to see. I think its preview should show a rendered http link, much like the preview of a file displays a link to a file. This is a separate issue, but I'm mentioning it in case it seems like the frameset is misbehaving :)

[Andy Altepeter (aaltepet)]

This would be a quick change -- would you like this for 2.1?

[Kit Blake (kitblake)]

Yes, it'll make things more consistent with the preview.

[Andy Altepeter (aaltepet)]

ok, done and checked in.

[Kit Blake (kitblake)]

This looks great and works perfectly with the new preview.

[Kit Blake (kitblake)]

An update in case anyone notices changed behavior: the change in the link preview made it possible to show a preview in tab_edit when the content is published. We've been doing this for some time with documents, but the intention was to do it with all versioned content. The Link preview was the problem, because it redirected. I've changed the code so the preview in tab_edit displays the rendered http link. I've reverted the 'tab_preview preview' because, with the new preview frame, it's perfectly fine to let the redirect happen since the user still has the Silva navigation above. (revision 29295)

[Andy Altepeter (aaltepet)]

I should mention that showing the link in the preview tab is actually quite useful. The particular use case that was mentioned initially was that authors needed to create a new version in order to see the URL the link points to.

With the most recent change, the preview tab now redirects (which was the original design). In order to see where the link goes, you still need to create a new version of the Silva Link. One could right-click "view frame info" the bottom preview tab frame. But the url you get is not necessarily the url that is entered in the Silva Link. An simple example would be if the Silva Link was 'http://cnn.com'. The URL in the 'view frame info' is http://www.cnn.com. A more complicated example would be a tinyurl.com url. Or a link which does an http redirect to the "current" document (more like a dynamic shortcut).

Perhaps if the edit tab of a published Silva Link displayed the rendered link?

[Andy Altepeter (aaltepet)]

ahh, now that I read the svn checkin that just arrived in my mailbox, I see that Kit has already done what I described.