terminator will cd to a non-existent directory upon split
Bug #208319 reported by
Michael Shapiro
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Terminator |
Fix Released
|
High
|
chantra | ||
terminator (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: terminator
shell-init throws:
"shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory"
and the new terminator terminal starts in a non-existent directory
Reproduction steps:
1. Open a non-terminator terminal.
2. $ mkdir ng_lubs_dongs
3. $ cd ng_lubs_dongs
4. $ terminator
5 (in terminator). $ rm -rf ng_lubs_dongs
6. Right-click and split the terminator window, note that terminator cd's to ng_lubs_dongs still.
FIX IT NG. <3
Changed in terminator: | |
status: | New → Confirmed |
Changed in terminator: | |
assignee: | nobody → chantra |
status: | Triaged → Fix Committed |
Changed in terminator: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is related to bug #181194. Not only do we need to be more sensible about where we get cwd from, we should also check before sending fork-command() that the requested cwd still exists and is a directory. Technically speaking that will produce a race condition, but the failure mode isn't dangerous AFAIK, and the chances of the directory disappearing in such a small window are pretty low.