'software deploy abort' fails to abort the deploy after the 'deploy-activate-failed'

[Luis Eduardo Bonatti]

Brief Description

'software deploy abort' fails to abort the deploy after the deploy-activate failed
Severity

Major

Steps to Reproduce

Login to system
source
software upload <iso> <sig>
software deploy precheck <rel-id>
software deploy start <rel-id>
system host-lock controller-0
software deploy host controller-0
system host-unlock controller-0
software deploy activate --> deploy activate fails
software deploy abort
Expected Behavior

Abort should be successful

Actual Behavior

Abort fails with the below error

[sysadmin@controller-0 ~(keystone_admin)]$ software deploy abort
Error:
Host can not transform to activate-rollback-pending from current state

Reproducibility

100% Reproducible

System Configuration

SX

Last Pass

NA

Timestamp/Logs

Alarms

None

Test Activity

Feature Testing

Workaround

NA

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/update/+/924783
Committed: https://opendev.org/starlingx/update/commit/b8087c0dd35242ed9caa8498af1126de469b166e
Submitter: "Zuul (22348)"
Branch: master

commit b8087c0dd35242ed9caa8498af1126de469b166e
Author: Luis Eduardo Bonatti <email address hidden>
Date: Tue Jul 23 17:18:17 2024 -0300

    Fix deploy transition state

    When software deploy abort is executed with deploy in activate-failed
    state a state transition error is raised, this commit fix issue by
    adding activate_rollback_pending to activate_failed list.

    Test Plan:
    PASS: software deploy abort after activate fails.

    Closes-bug: 2074208

    Change-Id: Ib49c3d259d8afe927f99d432fce9ba990037b2da
    Signed-off-by: Luis Eduardo Bonatti <email address hidden>