Bootstrap replay is erroneously executing tasks when no config changes are made

[Rakshith M R]

Brief Description
-----------------
Bootstrap replay is erroneously executing tasks in situations where no configuration changes are made.
For instance, the tasks guarded by restart_tasks should only be executed given a reconfig (e.g., networking config change).

However, the flag is unexpectedly set and tasks such as Shut down and remove Kubernetes components are executed unnecessarily.

Upon investigation it is found that last_bootstrap_config.j2 template was not configured properly and there is a mismatch while comparing previous configuration values with current configurations.

Severity
--------
Major

Steps to Reproduce
------------------
Execute bootstrap replay ensuring no config changes:

1. Using subcloud: Run phase operation to run deploy bootstrap before running deploy config
or
2. Using System Controller: re-run ansible-bootstrap before unlock

Expected Behavior
-----------------
Bootstrap replay doesn't run Shut down and remove Kubernetes components

Actual Behavior
---------------
Bootstrap replay runs Shut down and remove Kubernetes components

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
AIO-SX and DC

Test Activity
-------------
Developer Testing

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/924736

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/924736
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/d147f7a5fc6ff8428e797de82fc3192098578920
Submitter: "Zuul (22348)"
Branch: master

commit d147f7a5fc6ff8428e797de82fc3192098578920
Author: rakshith mr <email address hidden>
Date: Tue Jul 23 10:09:29 2024 -0400

    Fix for erroneously executing tasks while bootstrap replay

    Bootstrap replay is erroneously executing tasks in situations
    where no configuration changes are made.
    For instance, the tasks guarded by restart_tasks should only be
    executed given a reconfig.

    However, the flag is unexpectedly set and tasks such as Shut down
    and remove Kubernetes components are executed unnecessarily.

    Upon investigation it is found that last_bootstrap_config.j2
    template was not configured properly and there is a mismatch while
    comparing previous configuration values with current configurations.

    Test Plan:
    PASS: Deploy AIO-SX and verify last_bootstrap_config.yml file is
          updated as expected.
    PASS: Deploy/restore iso till bootstrap scripts are executed and
          check for updated last_bootstrap_config.yml file.
    PASS: Re-play ansible-bootstrap and confirm that the task
          'Shut down and remove Kubernetes components' is not executed.

    Closes-bug: 2073885

    Change-Id: Ifd7875dec5e034ce5a74f861e6e87fb4389cc7b8
    Signed-off-by: rakshith mr <email address hidden>