/usr/lib/kitty/kitty/options/definition.py:4116: SyntaxWarning: invalid escape sequence '\e' long_text='''

[Agathe Porte]

[ Impact ]

The package displays a warning when installing it or upgrading it
from a previous version. This warning can scare users who see it
in the terminal.

[ Test Plan ]

Try to install the patched package and verify that it still starts
fine. Check that the warning is gone when installing or upgrading
the package:

$ sudo dpkg -i ./kitty_xxx.deb # no warnings displayed during install
$ kitty # use as a terminal

[ Where problems could occur ]

Fixing the string wrongly can make the program behave wrongly.

[ Original Bug Report ]

Hello,

During the upgrade of kitty, I get the following warning:

Setting up kitty (0.32.2-1ubuntu0.1) ...
/usr/lib/kitty/kitty/options/definition.py:4116: SyntaxWarning: invalid escape sequence '\e'
  long_text='''

I this this file should be patched so the warning does not appear during upgrade.

[Agathe Porte (gagath)]

Seems to be patched in later versions, does not occur in an oracular chroot. Only needs to be fixed in Noble.

[Agathe Porte (gagath)]

Attached debdiff for Noble SRU update.

[Graham Inggs (ginggs)]

This FTBFS for me, it looks like the same error reported to Debian [1].
If you get it to build, please provide a log or link to a PPA build.

[1] https://bugs.debian.org/1074216

[Graham Inggs (ginggs)]

My mistake, I didn't realize I tried to build this package with a backport of python3.12 3.12.4.

It builds fine with python3.12 3.12.3 from Noble.

However, this means that kitty in Noble will likely FTBFS when python3.12 gets an update. Would you please look to see if it is feasible to backport the fix for the FTBFS in the same SRU?

[Agathe Porte (gagath)]

Attached v2 debdiff that will also fix the FTBFS with Python updates for the tarball DeprecationWarning (upstream cherry-pick).

[Graham Inggs (ginggs)]

Uploaded, thanks!

[Robie Basak (racb)]

In general this looks good.

> + * Backport upstream commit ecc44dffeb50746cc3e3019750226a80a50082a3
> + to fix test_ssh_leading_data with newer releases of Python

This sounds like it only affects tests, and thus is OK to add to the SRU without further analysis. However, I was unable to verify this in a few minutes, and you made no mention of it in the bug comments above. Are you sure that this affects tests only and regular use of the built binary package, and how can this be verified?

> [ Test Plan ]

> Try to install the patched package and verify that it still starts
> fine. Check that the warning is gone when installing or upgrading
> the package.

Please could you add a smoke test to the Test Plan, or if that is already being done with automatic tests, document how you have determined this? This would then help mitigate what you're already identified in your regression analysis.

It would also be nice to have dep3 headers in the quilt patches so that they can more easily be verified against upstream, but no need to re-upload just for that.

[Agathe Porte (gagath)]

Hello Robie,

> This sounds like it only affects tests, and thus is OK to add to the SRU
> without further analysis. However, I was unable to verify this in a few
> minutes, and you made no mention of it in the bug comments above. Are you sure
> that this affects tests only and regular use of the built binary package, and
> how can this be verified?

No, it fixes something that will fail during testing and was caught by an
upstream test that was run during build. The fix is an upstream cherry-pick
that fixes that. It is not related to the SRU, but was asked to be added
as well by Graham because the next SRU of Python would have broken it anyways.

> Please could you add a smoke test to the Test Plan, or if that is already
> being done with automatic tests, document how you have determined this? This
> would then help mitigate what you're already identified in your regression
> analysis.

I added a list of commands in the test plan. As I said you just have to install
the package and the warning is gone. Then I just use kitty as a regular
terminal.

> It would also be nice to have dep3 headers in the quilt patches so that they
> can more easily be verified against upstream, but no need to re-upload just
> for that.

Yes. However I do not see my package anymore in -proposed. If I need to do a
new upload, I can remove the git headers and use dep3 headers instead and
propose a new debdiff for someone to sponsor.