intel-vsc-dkms FTBS on jammy with the latest 6.8 hwe kernel

[Andrea Righi]

[Impact]

/var/lib/dkms/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.1/build/drivers/mfd/ljca.c:219:17: error: implicit declaration of function ‘strlcpy’; did you mean ‘strscpy’? [-Werror=implicit-function-declaration]
  219 | strlcpy(ids[0].id, hids[i], sizeof(ids[0].id));
      | ^~~~~~~
      | strscpy

[Test case]

install both GA and HWE kernels, and

 $ sudo apt install intel-vsc-dkms

then check that the build for both kernels succeeds

[Fix]

Backport the changes from noble to suppor the new linux 6.8 ABI.

[Regression potential]

We may experience regressions on Intel Alder Lake platforms with the Intel Vision Sensing Controller (IVSC), especially with the new 6.8 kernel.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: intel-vsc-dkms 0~git202211241536.70d95269-0ubuntu0.22.04.1
ProcVersionSignature: User Name 6.8.0-35.35.1~22.04.1-lowlatency 6.8.4
Uname: Linux 6.8.0-35-lowlatency x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSubPlatform: config-disk (/dev/vdb)
Date: Fri Jun 28 15:58:27 2024
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
SourcePackage: ivsc-driver
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

Test build with the new HWE kernel 6.8:

ljca.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

spi-ljca.ko:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

gpio-ljca.ko:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

i2c-ljca.ko:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

mei-vsc.ko:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

intel_vsc.ko:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

mei_csi.ko:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

mei_ace.ko:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

mei_pse.ko:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

mei_ace_debug.ko:
Running module version sanity check.
 - Original module
 - Installation
   - Installing to /lib/modules/6.8.0-35-lowlatency/updates/dkms/

Test build with GA kernel 5.15:

ljca.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

spi-ljca.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

gpio-ljca.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

i2c-ljca.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

mei-vsc.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

intel_vsc.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

mei_csi.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-115-generic/updates/dkms/

mei_ace.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /...

[Robie Basak (racb)]

Please amend the Test Plan to make it clear that testing both the GA and HWE kernels is required. I expect to see this in the Test Plan for every HWE backport fix (and if it's not required then an explanation as to why).

I understand that I could just do this myself but it feels like every time I look at an HWE backport fix this isn't in the Test Plan, so I'm pushing back now to get this done properly from the beginning. That way there will be less effort for everyone at a time that the SRU queues are quite large and efficiency matters.

[Timo Aaltonen (tjaalton)]

Hello Andrea, or anyone else affected,

Accepted ivsc-driver into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ivsc-driver/0~git202211241536.70d95269-0ubuntu0.22.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.